Wrong 'delta' count

Your test are correct. The switching delta count does not have an influence on the functionality of the module. Everything still works, this is probably why it has been undiscovered for so long.
I ll try to include a fix that stops the delta from changing once it is set in next release. Would you by any chance have written a patch for this problem feel fee to add it to this post.

This is a huge problem when using multigroups. For instance, I have a textfield of student next to a student's name. If the delta changes, then the student's name isn't paired with 'student', anymore, and is instead something else, like 'teacher'.

Thanks!

I just looked through all my fields, and pretty much all of them are broken in this way.

Really need this fix.

There's a secondary effect caused by this behavior.. When I set a specific order of referenced nodes in one node, the order changes when I save any one of those nodes.

Here is a patch that solves the problem http://drupal.org/node/73098 It still needs some reviewing so go ahead and review.

domidc, i think you linked to the wrong issue #73098: _quotes_install not being called? is for the Quotes module.

Oh, perhaps you meant #730986: Refactor to use content module's data APIs?

Yep, indeed. Wrong url

Please publish a new release with fixed delta count bug. Beside that I love this module!

The 3.3 release fixes this issue

Great, thanks a lot!!!

I'm afraid I'm seeing this still with 3.3 version. Here is my scenario.

1. A <===> B
2. B is single back to A
3. create node A1
4. create node B1 with ref back to A1
5. view node A1

When you look at A1 it has the noderef to B1 at delta 1 and delta 0 = NULL

The problem lies in $referenced_node->{$away_field}[] = array('nid' => $home_node->nid);. This always assumes that we're adding a new key to $referenced_node->{$away_field}.

This fixes it on insert, but we probably want to do the same checks anywhere we have:

$referenced_node->{$away_field}[] = array('nid' => $home_node->nid);

I can confirm that #15 fixes the issue. As sirkitree alludes too it will need to be applied to the update function as well.

Note that this issue also causes views filters that check for "Is empty (NULL)" on the referenced field to behave unpredictably.

Did this patch cause this new issue where adding a node reference while creating a node causes a double? Issue thread.

Now when we create a new node and simultaneously add a corresponding node reference, it gets created correctly on the new node, but on the other node, it gets added twice: once as delta=1 and once as delta=2 (no data for delta=0).

@heatherann

The patch in #15 has not been committed so unless you applied this patch to the module in your Drupal install then your issue stems from something perhaps related but not from this patch. Also, the other issue you reference in your post predates this patch.

I have found the same bug in my installation. It is worse, because if you have set one node reference field to single, than you you did not see the modules work. References with delta>0 would not be shown in the form.

The patch in #15 works for one direction if the single field is the first I think. There is another situation when CNR tries to update an "away" reference. I have made a small addition to the patch, here it is with the second code change AND the first change.

In version 6.4.dev I m working on. I have put in place checks to counter the NULL interfere with the deltas. I still have to check if it solves this issue.

This patch is included in the 6.4 version which is currently in dev