Currently the invalidations are offered together by the purge module and the cloudflarepurger is wrongly trying to handle just a single type of invalidations. This is a result of the check of just the first invalidation of the offered ones and assuming all others are the same. Could be that with older version of the purge module the invalidation method was called multiple types for every different type.
Here is a small rewrite so this is handled correctly.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | patch-9-11-diff.txt | 2.05 KB | piotr pakulski |
| #11 | 3129594-11.patch | 3.79 KB | piotr pakulski |
| #9 | allow-purge-simultaneous-methods-3129594-9.patch | 3.79 KB | kleinmp |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
gambryLet's see what testbot says.
Comment #3
alexj12 commented+1 on this patch working and code reviewed.
Comment #6
emersonreis.devGood work on the patch! I tested it as well and working fine and code looks good!
The Merge Request I opened does the chunking inside the purge method instead of on the invalidate method, that could help in case you got a invalidate everything in the middle of the list so instead of running loads of tags and URL API requests you just run the everything one.
Comment #7
perecedero.Updated @gambry path to work with the latest beta3 release.
Comment #8
rosk0This needs issue summary update, and if this is really a bug, than it needs at least steps to reproduce it, but ideally test that will prove the bug.
Comment #9
kleinmp commentedI rerolled this patch for the current 2.x-dev version.
Comment #10
piotr pakulskiConfirming patch #9 works great for me.
+1 for this issue to be merged
Reproduction steps:
- in drupal have node which when saved is going to refresh a content of some file that exists in public filesystem under specific url
- during the node save have some custom code that is adding the URL of the file to revalidation queue
- as a result in purge queue table we have a list of tags and the URL to invalidate
- when queue processed (drush pqw). Cache for tags invalided fine. Cache for URL not invalidated. No errors in logs
- when adding URL to queue manually by drush. The URL is the only item in the queue. Running drush paqw. The URL is indeed invalidated
Comment #11
piotr pakulskiActually the patch #9 is failing for type "everything"
there is leftover in the patch - fixed that and attaching the new working version of the patch.
Comment #12
piotr pakulskiComment #13
rosk0Hi Piotr,
Thanks for progressing this, but in order for it to receive proper review the patch should be converted to a merge request. There is already one exists feel free to use that or create a new one.
Adding tags for #8.