Problem/Motivation

Add a detailed view to SPA (K8s Cluster Roles)

Issue fork cloud_dashboard-3258858

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !35

sekinet’s picture

sekinet CreditAttribution: sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@sekinet

Thank you for adding the detailed view. It looks good to me.

@ryo-yamashita

What do you think?

Thanks!

Ryo Yamashita’s picture

Ryo Yamashita CreditAttribution: Ryo Yamashita commented
Status: Needs review » Reviewed & tested by the community

@yas

I have built and checked the code and it appears to work fine. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Thank you for your review.

@sekinet

Cloud you please rebase and push the patch into 3258116-release-4.0.0-prepare of #3258116: Release 4.0.0 Assigned to: yas. Thanks!

sekinet’s picture

sekinet CreditAttribution: sekinet commented
Status: Needs work » Needs review

@yas

I've rebased and pushed the patch into 3258116-release-4.0.0-prepare of #3258116: Release 4.0.0. Could you please check it?

Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 68dd8aa on 4.x authored by sekinet 
    Issue #3258858 by sekinet, yas, Ryo Yamashita: Add a detailed view to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.