Problem/Motivation

  • Fix the errors of phpstan (6) (aws_cloud)
CommentFileSizeAuthor
#12 3399993-12-hotfix.patch1.91 KBxiaohua guan

Issue fork cloud-3399993

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !2092

yas made their first commit to this issue’s fork.

xiaohua guan’s picture

xiaohua guan commented
Title: Fix the errors of phpstan (5) (aws_cloud) » Fix the errors of phpstan (6) (aws_cloud)
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@xiaohua-guan

Thank you for the refactoring. Can you rebase the patch? Also, can you please include the following warning fixes?

$ phpstan analyze .

...

------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   modules/cloud_service_providers/aws_cloud/tests/src/Unit/Plugin/cloud/launch_template/AwsCloudLaunchTemplatePluginTest.php  
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  70     Missing call to parent::setUp() method.                                                                                     
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

...

 ------ ----------------------------------------------------------------------------------------- 
  Line   modules/cloud_service_providers/aws_cloud/tests/src/Unit/Service/Ec2/Ec2ServiceTest.php  
 ------ ----------------------------------------------------------------------------------------- 
  117    Missing call to parent::setUp() method.                                                  
 ------ ----------------------------------------------------------------------------------------- 

...

Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I've rebased the code. And also I fixed the code. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I'll merge the patch to 6.x, and close this issue as Fixed.

  • yas committed 591709df on 6.x authored by Xiaohua Guan 
    Issue #3399993 by Xiaohua Guan, yas: Fix the errors of phpstan (6) (...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
xiaohua guan’s picture

xiaohua guan commented
Status: Fixed » Needs review
StatusFileSize
new 3399993-12-hotfix.patch1.91 KB

@yas

I added a hotfix. Please take a look. Thanks.

Xiaohua Guan opened merge request !2097

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xioahua-guan

Thank you for the hotfix. I have ran the PHPUnit tests several times and it looks good. I'll merge the patch to 6.x, and close this issue as Fixed.

  • yas committed cfe13b54 on 6.x authored by Xiaohua Guan 
    Issue #3399993 by Xiaohua Guan, yas: Hotfix - Fix the errors of phpstan...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.