Problem/Motivation

  • Add a BDD test suite for OpenStack instance (Network interface)

Issue fork cloud-3386712

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !2010

masami’s picture

masami commented
Status: Active » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Needs work

@Masami (@yas)

I reviewed the test scenario. No additional comments from me.
Please check Fukuyama's comment. thanks.

masami’s picture

masami commented
Status: Needs work » Needs review
ufuku5’s picture

ufuku5 commented
Status: Needs review » Reviewed & tested by the community

I confirmed that it has been fixed

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@asai.noriaki @ufuku5

Thank you for your review.

@masami

Thank you for the patch. Please rebase it to merge.

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 397ab336 on 6.x authored by Masami 
    Issue #3386712 by Masami, yas, asai.noriaki, ufuku5: Add a BDD test...

  • yas committed cbead5eb on 5.x authored by Masami 
    Issue #3386712 by Masami, yas, asai.noriaki, ufuku5: Add a BDD test...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
masami’s picture

masami commented
Status: Fixed » Needs work

Masami opened merge request !2064

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Can you please rebase the hotfix due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

Sorry, can you please rebase the patch again due to the previous merge?

Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed e3f715a0 on 6.x authored by Masami 
    Issue #3386712 by Masami, yas, asai.noriaki, ufuku5: Hotfix - Add a BDD...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed f0ae93ed on 5.x authored by Masami 
    Issue #3386712 by Masami, yas, asai.noriaki, ufuku5: Hotfix - Add a BDD...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.