Problem/Motivation

  • Add "action log" feature for openstack instance
CommentFileSizeAuthor
#7 fixedphpcs.png43.64 KBraveen_thakur51

Issue fork cloud-3370000

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1859

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. Can you please fix the following coding standards error? Thanks

FILE: ..._providers/openstack/src/Form/OpenStackInstanceActionLogForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 97 | WARNING | Unused variable $id.
----------------------------------------------------------------------
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I've fixed it. Please take a look again. Thanks.

raveen_thakur51’s picture

raveen_thakur51 commented
StatusFileSize
new fixedphpcs.png43.64 KB

Hello Guys,
I have installed the module with version 6. x-dev. The coding standards errors are fixed.
I am adding a screenshot for reference.
Please have a look. And Thank You.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add "action log" feature for openstack instance » Add the action log of the OpenStack instance
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update. I posted my comment. Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Please check the comment. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@raveen-thakur

Thank you for your review.

@xiaohua-guan

Thank you for your explanation. It makes sense. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 7dbc8982 on 6.x authored by Xiaohua Guan 
    Issue #3370000 by Xiaohua Guan, yas, Raveen Thakur: Add the action log...

  • yas committed 815fbde0 on 5.x authored by Xiaohua Guan 
    Issue #3370000 by Xiaohua Guan, yas, Raveen Thakur: Add the action log...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.