Problem/Motivation

  • Add the function to specify an OpenStack port in the OpenStack instance attach interface form

Issue fork cloud-3365514

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1825

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Specify port in instance attach interface form (2) - implement » Add the function to select an OpenStack port in the OpenStack instance attach interface form
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +chatgpt

@xiaohua-guan

Thank you for the patch. It looks good to me. I posted the refactoring comments. Thanks

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. It looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed cdfe2842 on 6.x authored by Xiaohua Guan 
    Issue #3365514 by Xiaohua Guan, yas: Add the function to select an...

  • yas committed 2b621d51 on 5.x authored by Xiaohua Guan 
    Issue #3365514 by Xiaohua Guan, yas: Add the function to select an...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.