Problem/Motivation

  • Add the functionality of 'Termination Protection' to OpenStack instance - edit form

Issue fork cloud-3364751

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1819

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. I posted my comments. Thanks!

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

Thanks for your comments. I've fixed them.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. It looks good to me. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Add the functionality of 'Termination Protection' to OpenStack instance - edit form » Add the functionality of 'Termination Protection' to OpenStack instance (Edit form)

  • yas committed 6d5af3a7 on 6.x authored by Xiaohua Guan 
    Issue #3364751 by Xiaohua Guan, yas: Add the functionality of '...

  • yas committed fb6bee3b on 5.x authored by Xiaohua Guan 
    Issue #3364751 by Xiaohua Guan, yas: Add the functionality of '...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.