Problem/Motivation

  • Add missing schema of cloud_dashboard.settings in drupal/cloud_dashboard

Issue fork cloud-3363458

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Masami created an issue. See original summary.

Masami opened merge request !1804

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Needs review » Needs work

@masami

Thank you for the refactoring. It looks good; and I posted my comments. Thanks!

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Add missing schema of cloud_dashboard.settings in drupal/cloud_dashboard » Add a missing schema of cloud_dashboard.settings in drupal/cloud_dashboard

  • yas committed 3acc55ae on 6.x authored by Masami 
    Issue #3363458 by Masami, yas: Add a missing schema of cloud_dashboard....

  • yas committed 4f53cef7 on 5.x authored by Masami 
    Issue #3363458 by Masami, yas: Add a missing schema of cloud_dashboard....
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
Masami’s picture

Masami CreditAttribution: Masami commented
Status: Fixed » Needs work

Masami opened merge request !1809

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@masami

Thank you for the hotfix.

Can you please rebase the patch due to the previous merge?

Thanks!

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed ff6fca1e on 6.x authored by Masami 
    Issue #3363458 by Masami, yas: Hotfix - Add a missing schema of...

  • yas committed 740a2f85 on 5.x authored by Masami 
    Issue #3363458 by Masami, yas: Hotfix - Add a missing schema of...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.