Problem/Motivation

  • Remove a refresh button for Authenticated user for all OpenStack resources.

Issue fork cloud-3361362

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nakamurarts created an issue. See original summary.

nakamurarts opened merge request !1790

nakamurarts’s picture

nakamurarts CreditAttribution: nakamurarts commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes

@nakamurarts

Thank for the patch. It looks good to me.

@baldwinlouie

What do you think?

Thanks

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@nakamurarts @yas, thank you for the patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@baldwinlouie

Thank you for your review.

@nakamurarts

I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

nakamurarts’s picture

nakamurarts CreditAttribution: nakamurarts commented

@yas @baldwinlouie

Thank you all for your reviews.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Needs work

@hostomitm

I ran the BDD tests and found some errors regarding Refresh button. Can you please check the patch? Probably the BDD test scenarios need to be modified or the patch should be fixed. Thanks

nakamurarts’s picture

nakamurarts CreditAttribution: nakamurarts commented
Status: Needs work » Needs review
nakamurarts’s picture

nakamurarts CreditAttribution: nakamurarts commented

After a long time, I've finally completed the correction for the BDD tests.
Please review. Thank you!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@nakamurarts

Thank you for the patch. I have one question. Can you take a look at it? Thanks!

nakamurarts’s picture

nakamurarts CreditAttribution: nakamurarts commented
Status: Needs work » Needs review

@yas
Thank you for the review, I have responded to your comment.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Title: Remove a refresh button for an authenticated user » Remove refresh buttons for an authenticated user
Status: Needs review » Reviewed & tested by the community

@nakamurarts

Thank you for your explanation. I understand it. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas credited sekinet.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

  • yas committed 33f0d99a on 6.x authored by nakamurarts 
    Issue #3361362 by yas, nakamurarts, baldwinlouie, sekinet: Remove...

  • yas committed 58eb2b74 on 5.x 
    Issue #3361362 by yas, nakamurarts, baldwinlouie, sekinet: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.