Problem/Motivation

  • Fix JavaScript error "404 error" if VMware module isn't installed

Issue fork cloud-3355954

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !1738

masami’s picture

masami commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +chatgpt

@masami

Thank you for the fix. I posted my comment. Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good and makes sense to me. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

Thank you for the update. It looks good and makes sense to me. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix JavaScript error "404 error" if VMware module isn't installed » Fix a JavaScript error "Failed to load resource: the server responded with a status of 404 (Not Found)" if the drupal/vmware module isn't installed

  • yas committed 97100586 on 6.x authored by Masami 
    Issue #3355954 by Masami, yas: Fix a JavaScript error "Failed to load...

  • yas committed 1e122a26 on 5.x authored by Masami 
    Issue #3355954 by Masami, yas: Fix a JavaScript error "Failed to load...

  • yas committed 7f8804e9 on 4.x authored by Masami 
    Issue #3355954 by Masami, yas: Fix a JavaScript error "Failed to load...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@masami

Please let us re-open this issue since the patch wasn't enough to fix the issue. We have the following error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'entityTypeId')

I think there are still hard-coded portion: CLOUD_SERVICE_PROVIDER_INFO at https://git.drupalcode.org/project/cloud/-/blob/6.x/modules/cloud_dashbo...

Can you please double-check the issue?

Thanks

Masami opened merge request !1742

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Thank you for the hotfix. I tested the patch and it fixes the error. I posted my comments. Thanks!

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@masami

Can you please rebase the patch due to the previous merge? Thanks

masami’s picture

masami commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

  • yas committed 444b6e5b on 6.x authored by Masami 
    Issue #3355954 by Masami, yas: Hotfix - Fix a JavaScript error "Failed...

  • yas committed 3b9547e1 on 5.x authored by Masami 
    Issue #3355954 by Masami, yas: Hotfix - Fix a JavaScript error "Failed...

  • yas committed 72c47e27 on 4.x authored by Masami 
    Issue #3355954 by Masami, yas: Hotfix - Fix a JavaScript error "Failed...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.