• Add a BDD test suite for launching template(git)

Issue fork cloud-3279817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

makoto suzuki created an issue. See original summary.

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Active » Needs work
makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Issue summary: View changes

makoto suzuki opened merge request !922

yas made their first commit to this issue’s fork.

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for your providing this patch. Can you check my comments?

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

Thanks for the update. Except missing a whitespace , it looks good.

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented

Thank you for making sure.
I added whitespace and rebase done.

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks for your update. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

@kumikoono

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

makoto suzuki opened merge request !980

makoto suzuki closed merge request !980

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@makoto-suzuki

Thank you for the update. I posted my comment. Could you please check it? Thanks!

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@makoto-suzuki

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed f38cbef on 5.x authored by makoto suzuki 
    Issue #3279817 by makoto suzuki, yas, kumikoono: Add a BDD test suite...

  • yas committed fd78f74 on 4.x authored by makoto suzuki 
    Issue #3279817 by makoto suzuki, yas, kumikoono: Add a BDD test suite...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Fixed » Needs work

This needs to address the merge conflict.

makoto suzuki opened merge request !985

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks for the fix.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@kumikoono

Thank you for your review.

@makoto-suzuki

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 73dfe02 on 5.x authored by makoto suzuki 
    Issue #3279817 by makoto suzuki, yas, kumikoono: Hotfix - Add a BDD test...

  • yas committed aec646d on 4.x authored by makoto suzuki 
    Issue #3279817 by makoto suzuki, yas, kumikoono: Hotfix - Add a BDD test...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Fixed » Needs work

Change the launch user of the launch template from cloud administrator to BDD user.

makoto suzuki opened merge request !1016

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented

I changed the run of launch a launch template from cloud adminitrator role to BDD user and ran run_behat.
I was able to browse the deployment pod without any problems.
Modify isssu and submit a review request.

makoto suzuki’s picture

makoto suzuki CreditAttribution: makoto suzuki commented
Status: Needs work » Needs review
kumikoono’s picture

kumikoono CreditAttribution: kumikoono at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

Thanks for your update. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@kumikoono

Thank you for your review.

@makoto-suzuki

Thank you for the hotfix. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 80252ff on 5.x authored by makoto suzuki 
    Issue #3279817 by makoto suzuki, yas, kumikoono: Hotfix - Add a BDD test...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

  • yas committed d6827dc on 4.x authored by makoto suzuki 
    Issue #3279817 by makoto suzuki, yas, kumikoono: Hotfix - Add a BDD test...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.