Problem/Motivation

Copy security group from Cloud Orchestrator master to workers (AWS Cloud)

Issue fork cloud-3258845

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !609

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review

@yas @baldwinlouie

Please review the commit code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. I posted my minor comments. Could you please check them? Thanks!

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

I've fixed the code. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@xiohua-guan

Thank you for the update. It looks good to me. I found there is a return type hint was missing. Thanks!

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

Thanks for your review. I've fixed them. Please take a look again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented

@xiaohua-guan

Thank you for the update. It looks good to me now.

@baldwinlouie

Could you please review the patch? Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@xiaohua-guan

I found one coding standard violation at https://www.drupal.org/pift-ci-job/2296276. Could you please fix it? Thanks!

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

I've fixed it. Please take a look again, Thanks.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@yas and @xiaohua-guan, thanks for the patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed b5afe33 on 4.x authored by Xiaohua Guan 
    Issue #3258845 by Xiaohua Guan, yas, baldwinlouie: Copy security group...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas as a volunteer and at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.