Problem/Motivation

  • Fix the following error with TerraformVariableDeleteMultipleForm
    Fatal error: Declaration of Drupal\terraform\Form\TerraformVariableDeleteMultipleForm::getCancelUrl(): Drupal\Core\Url must be compatible with Drupal\terraform\Form\TerraformDeleteMultipleForm::getCancelUrl(): Drupal\Core\Security\TrustedCallbackInterface in /Users/baldwin/Devel/Docomo/distro.drupal.dev/docroot/modules/contrib/cloud/modules/cloud_service_providers/terraform/src/Form/TerraformVariableDeleteMultipleForm.php on line 26
CommentFileSizeAuthor
#12 359.patch863 bytesyas
#2 distro_test_8080_core_install_php_rewrite_ok_profile_cloud_orchestrator_langcode_en_and_Max_s_Restaurant__S__San_Francisco__-_South_San_Francisco__CA_94080__Menu___Order_Online_.png897.62 KBbaldwinlouie

Issue fork cloud-3229021

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new distro_test_8080_core_install_php_rewrite_ok_profile_cloud_orchestrator_langcode_en_and_Max_s_Restaurant__S__San_Francisco__-_South_San_Francisco__CA_94080__Menu___Order_Online_.png897.62 KB

baldwinlouie opened merge request !359

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

As I was testing Terraform permissions, I came across this error. I'm uploading a PR to fix this.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix 500 Error with TerraformVariableDeleteMultipleForm » Fix an Internal Server Error: Declaration of TerraformVariableDeleteMultipleForm::getCancelUrl(): Url must be compatible with getCancelUrl(): TrustedCallbackInterface
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for fixing the error. It looks good to me. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 3760e5d on 4.x authored by baldwinlouie 
    Issue #3229021 by baldwinlouie, yas: Fix an Internal Server Error:...

yas closed merge request !359

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

We need to fix a coding standard violation: https://www.drupal.org/pift-ci-job/2155159

yas reopened merge request !359

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

Changing the status to Needs review

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 359.patch863 bytes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

The tests have been passed successfully, so I'll merge the patch to 4.x, and close this issue as Fixed.

  • yas committed 840c1fd on 4.x 
    Issue #3229021 by yas: Hotfix - Fix an Internal Server Error:...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yas closed merge request !359