Problem/Motivation

CommentFileSizeAuthor
#7 3189974-7.patch76.71 KByas
#5 3189974-5.patch67.16 KBPooja Ganjage
#3 3189974-3.patch67 KBPooja Ganjage

Issue fork cloud-3189974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3189976: Fix a deprecated function drupalPostForm() to submitForm() (2) (K8s), +#3189975: Fix a deprecated function drupalPostForm() to submitForm() (3) (OpenStack)
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3189974-3.patch67 KB

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3189974-5.patch67.16 KB

yas opened merge request !83

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3189974-7.patch76.71 KB

@pooja-ganjage

Thank you for supplying the patch. I refactored the following:

  1. Every single submitForm() requires drupalGet() before we call it.
  2. We need $this->t() for every single string (label) such as 'Save'.
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@all

I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed f769299 on 3.x 
    Issue #3189974 by yas, Pooja Ganjage: Fix a deprecated function...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3190170: Fix a deprecated function drupalPostForm() to submitForm() (6) (Cloud)

yas closed merge request !83

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3190294: Fix CloudServerTemplatePlugins for Drupal 9.2.x
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Assigned: Unassigned » yas

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.