Problem/Motivation

  • Manage Transit Gateways (Edit)
CommentFileSizeAuthor
#10 dev1.dataninja.net_clouds_aws_cloud_aws_us_west_2_transit_gateway_2_edit.png533.81 KByas
#10 3187780-10.patch14.65 KByas
#5 3187780-5.patch14.65 KByas

Issue fork cloud-3187780

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
Assigned: Unassigned » xiaohua guan

Xiaohua Guan opened merge request !57

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3187780-5.patch14.65 KB

Status: Needs review » Needs work

The last submitted patch, 5: 3187780-5.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for adding the feature. I had the following error with Druapl 9.2.x. The code looks good but could you please double-check?

Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "aws_cloud_transit_gateway" entity type did not specify a "edit" form class. in Drupal\Core\Entity\EntityTypeManager->getFormObject() (line 223 of /var/www/html/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

xiaohua guan’s picture

xiaohua guan commented

@yas

I checked the source code. I can't find anything wrong. Could you confirm it again after you clear the cache?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3187780-10.patch14.65 KB
new dev1.dataninja.net_clouds_aws_cloud_aws_us_west_2_transit_gateway_2_edit.png533.81 KB

@xiaohua-guan

I cleared the caches but it didn't help. I restarted memcached and apache2 on my local test environment, then it started working! I'll merge the patch to 3.x and close this issue as Fixed.

2_edit.png

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: 3187780-10.patch, failed testing. View results

  • yas committed add3489 on 3.x 
    Issue #3187780 by yas, Xiaohua Guan: Manage Transit Gateways (Edit)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs work » Fixed

yas closed merge request !57

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.