Problem/Motivation

  • Implement OpenStackService to use OpenStack native API for Key Pairs List and Operations
CommentFileSizeAuthor
#33 3185809-33.patch17.83 KBjigish.addweb
#32 3185809-32.patch17.83 KBjigish.addweb
#29 3185809-29.patch17.04 KBjigish.addweb
#28 3185809-28.patch17.04 KBjigish.addweb
#26 dev1.dataninja.net_clouds_openstack_dii_regionone_.png435.25 KByas
#24 3185809-24.patch14.67 KBjigish.addweb
#19 3185809-19.patch38.71 KBjigish.addweb
#15 3185809-14.patch35.89 KBjigish.addweb
#13 3185809-13.patch36.04 KBjigish.addweb
#10 3185809-10.patch34.94 KBjigish.addweb
#7 3185809-7.patch104.88 KByas

Issue fork cloud-3185809

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Issue summary: View changes

jigish.addweb opened merge request !38

jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3185809-7.patch104.88 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

I refactored the code as per your MR comment.

Please review the latest patch.

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-10.patch34.94 KB

Status: Needs review » Needs work

The last submitted patch, 10: 3185809-10.patch, failed testing. View results

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-13.patch36.04 KB

Status: Needs review » Needs work

The last submitted patch, 13: 3185809-13.patch, failed testing. View results

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3185809-14.patch35.89 KB

Status: Needs review » Needs work

The last submitted patch, 15: 3185809-14.patch, failed testing. View results

jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3185809-19.patch38.71 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

I tested the patch and it looks good to me. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed cd7664d on 3.x authored by jigish.addweb 
    Issue #3185809 by jigish.addweb, yas: Implement OpenStackService to use...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@jigishaddweb

I found there were some codes to be refactored. Could you please fix it?

Thanks

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-24.patch14.67 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new dev1.dataninja.net_clouds_openstack_dii_regionone_.png435.25 KB

@jigishaddweb

Thank you for the refactoring. The code looks good but could you please fix the following?

regionone_.png

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-28.patch17.04 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-29.patch17.04 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@jigishaddweb

Can you create / fork a new git repository on this issue and create MR on it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@jigishaddweb

...Or please rebase the source branch onto 3.x.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-32.patch17.83 KB
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3185809-33.patch17.83 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Thank you for your review.

Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. It looks good. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed ed37c01 on 3.x authored by jigish.addweb 
    Issue #3185809 by jigish.addweb, yas: Refactor OpenStackService to use...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !38

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.