Problem/Motivation

Fix following typos in K8s blocks:

  • $memoryl_usage_tota → $memory_usage_total
  • infomation → information
  • janky → junky
CommentFileSizeAuthor
#4 3185500-4.patch10.81 KBmasami
#2 3185500.patch10.81 KBmasami

Comments

Masami created an issue. See original summary.

masami’s picture

masami commented
Status: Active » Needs review
StatusFileSize
new 3185500.patch10.81 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work 
+++ b/modules/cloud_service_providers/k8s/src/Plugin/Block/K8sProjectCostsBlock.php
@@ -184,7 +184,7 @@ class K8sProjectCostsBlock extends K8sBaseBlock {
+    $memoryl_usage_total = 0;

@@ -235,7 +235,7 @@ class K8sProjectCostsBlock extends K8sBaseBlock {
+        $memoryl_usage_total += $memory_usage;

@@ -278,7 +278,7 @@ class K8sProjectCostsBlock extends K8sBaseBlock {
+      'data' => $this->k8sService->formatMemoryUsage($memoryl_usage_total, $memory_capacity),

Thank you for fixing the typos. Still having the type?

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3185500-4.patch10.81 KB

@yas
Thank you for your review.
I updated the patch, so please review it again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good to me now. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 79689c6 on 8.x-2.x authored by Masami 
    Issue #3185500 by Masami, yas: Fix typos in K8s blocks

  • yas committed 86f3095 on 3.x authored by Masami 
    Issue #3185500 by Masami, yas: Fix typos in K8s blocks
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.