CommentFileSizeAuthor
#18 3178322-18.patch37.58 KBxiaohua guan
#16 3178322-16.patch35.87 KBxiaohua guan
#13 3178322-13.patch36.63 KBxiaohua guan
#11 3178322-11.patch34.31 KBxiaohua guan
#8 3178322-8.patch32.49 KBxiaohua guan
#7 screenshot 2020-10-22 1.56.39.png224.25 KByas
#7 screenshot 2020-10-22 1.56.27.png121.26 KByas
#5 3178322-5.patch23.48 KBxiaohua guan
#3 3178322-3.patch23.47 KBxiaohua guan

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
Issue summary: View changes
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
StatusFileSize
new 3178322-3.patch23.47 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3178322-3.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
StatusFileSize
new 3178322-5.patch23.48 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new screenshot 2020-10-22 1.56.27.png121.26 KB
new screenshot 2020-10-22 1.56.39.png224.25 KB

@xiaohua-guan

Thank you for adding the feature. I tested the patch; I found:

  1. The form didn't change?
    56.27.png
  2. When I click Refresh button a couple of time, the duplicate entities are increased.
    .27.png

Could you please double-check?

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3178322-8.patch32.49 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 3178322-8.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
StatusFileSize
new 3178322-11.patch34.31 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3178322-11.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
StatusFileSize
new 3178322-13.patch36.63 KB
xiaohua guan’s picture

xiaohua guan commented

@yas

Please review the patch file. Thanks.

Status: Needs review » Needs work

The last submitted patch, 13: 3178322-13.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
StatusFileSize
new 3178322-16.patch35.87 KB

Status: Needs review » Needs work

The last submitted patch, 16: 3178322-16.patch, failed testing. View results

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3178322-18.patch37.58 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

Thank you for adding the feature. I tested the patch and it looks perfect now. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 780b912 on 3.x authored by Xiaohua Guan 
    Issue #3178322 by Xiaohua Guan, yas: Support a Carrier IP capability in...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.