CommentFileSizeAuthor
#7 3074715-7-interdiff.patch1.44 KByas
#6 3074715-6.patch16.59 KBnmani
#4 3074715-4.patch15.93 KBnmani
#2 3074715-2.patch15.9 KBnmani

Comments

nmani created an issue. See original summary.

nmani’s picture

nmani commented
Status: Active » Needs review
StatusFileSize
new 3074715-2.patch15.9 KB

Completed refactoring of aws_cloud.routing.yml and fixed annotation of image.php

Status: Needs review » Needs work

The last submitted patch, 2: 3074715-2.patch, failed testing. View results

nmani’s picture

nmani commented
Status: Needs work » Needs review
StatusFileSize
new 3074715-4.patch15.93 KB

Restored entity.aws_cloud_key_pair.edit_form.edit

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@nmani

The test has been passed successfully however unfortunately restoring entity.aws_cloud_key_pair.edit_form.edit doesn't seem to be a right solution.

Please search entity.aws_cloud_key_pair.edit_form.edit in the entire code and you'll find the following code in ./modules/cloud_service_providers/aws_cloud/aws_cloud.links.action.yml.

entity.aws_cloud_key_pair.edit:
  route_name: entity.aws_cloud_key_pair.edit_form.edit
  title: 'Edit'
  appears_on:
    - entity.aws_cloud_key_pair.canonical

Could you please fix it to entity.aws_cloud_key_pair.edit_form and try to test it again?

nmani’s picture

nmani commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3074715-6.patch16.59 KB

Updated as per @Yas comment

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3074715-7-interdiff.patch1.44 KB

@nmani

Thank you for the updated patch. It looks good to me now.

@baldwinlouie
@xiaohua-guan
@masami

What do you think?

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@all, thank you @nmani for the patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed. Also, I'll create 8.x-1.1 and 8.x-2.x-alpha1 based on this commit.

  • yas committed 02ab8ea on 8.x-1.x authored by nmani 
    Issue #3074715 by nmani, yas, baldwinlouie: Refactor the routing on each...

  • yas committed 0d1a336 on 8.x-2.x authored by nmani 
    Issue #3074715 by nmani, yas, baldwinlouie: Refactor the routing on each...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.