Closed (fixed)
Project:
Cloud
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
23 Apr 2019 at 06:58 UTC
Updated:
8 May 2019 at 00:19 UTC
Jump to comment: Most recent, Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3050106-10.patch | 14.73 KB | yas |
Comments
Comment #2
xiaohua guan commentedComment #3
xiaohua guan commentedComment #4
xiaohua guan commentedComment #5
xiaohua guan commentedFixed code related to coding standard messages.
Comment #6
xiaohua guan commented@yas
Please review the patch file. Thanks.
In the patch file, I also fixed the following bug.
When clicking save button in the Ec2 instance edit form, the error "Field elastic_ip_link doesn't exist" occurred.
Comment #7
yas@xiaohua-guan
Thank you for providing the patch. It looks good, I like your idea.
@baldwinlouie
@masami
What do you think?
Comment #8
baldwinlouie commentedCan we make the key #not_field to keep consistent with form api array key declaration?
https://www.drupal.org/docs/8/api/form-api/form-render-elements In this doc, all the array keys use underscores.
Comment #9
yas@baldwinlouie,
+1, nice catch.
Comment #10
yas@xiaohua-guan
@baldwinlouie
I just quickly updated the patch based on @baldwinlouie's comment at #8. Could you please review it?
Comment #11
baldwinlouie commented@all, this is good to me.
Comment #12
xiaohua guan commented@all
It is ok to me.
Comment #13
yas@all
Thank you for your efforts. I'll merge the patch to
8.x-1.cand8.x-2.xand close this issue asFixed.I'll release
8.x-1.1-beta1based on this patch's commit.Comment #16
yas