Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

StatusFileSize
new9.15 KB
xiaohua guan’s picture

StatusFileSize
new13.39 KB
xiaohua guan’s picture

StatusFileSize
new14.76 KB
xiaohua guan’s picture

Fixed code related to coding standard messages.

xiaohua guan’s picture

Status: Active » Needs review

@yas

Please review the patch file. Thanks.

In the patch file, I also fixed the following bug.

When clicking save button in the Ec2 instance edit form, the error "Field elastic_ip_link doesn't exist" occurred.

yas’s picture

@xiaohua-guan

Thank you for providing the patch. It looks good, I like your idea.

@baldwinlouie
@masami

What do you think?

baldwinlouie’s picture

+++ b/modules/cloud_service_providers/aws_cloud/src/Form/Ec2/InstanceEditForm.php
@@ -157,6 +157,7 @@ class InstanceEditForm extends AwsCloudContentForm {
+            '#notField'      => TRUE,

Can we make the key #not_field to keep consistent with form api array key declaration?

https://www.drupal.org/docs/8/api/form-api/form-render-elements In this doc, all the array keys use underscores.

yas’s picture

@baldwinlouie,

+1, nice catch.

yas’s picture

StatusFileSize
new14.73 KB

@xiaohua-guan
@baldwinlouie

I just quickly updated the patch based on @baldwinlouie's comment at #8. Could you please review it?

baldwinlouie’s picture

@all, this is good to me.

xiaohua guan’s picture

@all

It is ok to me.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@all

Thank you for your efforts. I'll merge the patch to 8.x-1.c and 8.x-2.x and close this issue as Fixed.

I'll release 8.x-1.1-beta1 based on this patch's commit.

  • yas committed 8ff6b48 on 8.x-1.x
    Issue #3050106 by Xiaohua Guan, yas, baldwinlouie: Trim text fields in...

  • yas committed c011e5e on 8.x-2.x
    Issue #3050106 by Xiaohua Guan, yas, baldwinlouie: Trim text fields in...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.