Expand the permissions for cloud server template entities to include

  • View any published cloud server template entities
  • View own published cloud server template entities
  • View any unpublished cloud server template entities
  • View own unpublished cloud server template entities
  • Edit any cloud server template entities
  • Edit own cloud server template entities
  • Delete any cloud server template entities
  • Delete own cloud server template entities
CommentFileSizeAuthor
#9 3031735-2.patch26.84 KBbaldwinlouie
#8 3031735-1.patch28.73 KBbaldwinlouie
#5 screenshot-2019-02-08c.png177.83 KByas
#5 screenshot-2019-02-08b.png64.91 KByas
#5 screenshot-2019-02-08a.png361.11 KByas
#2 3031735.patch14.13 KBbaldwinlouie

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new 3031735.patch14.13 KB

Attaching patch that adds the permissions described above. As part of this patch, I did a little refactoring to CloudContentListBuilder.php

Also, @yas, I didn't need to do any query altering. After we talked about it, I looked through the code and realized that Cloud server templates did not use Views to build the listing page :) It still used the old style ListBuilder class.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie,

Thank you for the patch！ It looks good to me but could you please fix the coding standards warnings?

It looks 14 more than branch result according to https://www.drupal.org/pift-ci-job/1195068

@xiaohua-guan

What do you think?

baldwinlouie’s picture

baldwinlouie commented

@yas, working on the coding syntax now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new screenshot-2019-02-08a.png361.11 KB
new screenshot-2019-02-08b.png64.91 KB
new screenshot-2019-02-08c.png177.83 KB

@baldwinlouie,

Thanks, actually I like these permission additions in this patch since an IT admin can provide Server Template to the user w/o giving Edit permission (Screenshot 1). Now the Server Templates can show the only Launch button for the operation. (Screenshot 2, Screenshot 3)

Screenshot 1
screenshot 1

Screenshot 2
screenshot 2

Screenshot 3
screenshot 3

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new 3031735-1.patch28.73 KB
baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review
StatusFileSize
new 3031735-2.patch26.84 KB

rerolling the patch.

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Reviewed & tested by the community

@yas, @baldwinlouie

It looks OK to me. So I will change the status to RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for the updated patch. The code got even better quality now.

@xiaohua-guan

Thank you for your review. I'll merge the patch and close this issue as Fixed.

  • yas committed 39ad8e0 on 8.x-1.x authored by baldwinlouie 
    Issue #3031735 by baldwinlouie, yas, Xiaohua Guan: Add more cloud server...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

@team,

I'll push a tag for 8.x-1.0-rc2 with this patch and create a release for RC2.

Thank you for your hard work！

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.