It's quite common to see error's like this coming from the module:

The value in This field has to be greater than x

"This field" starts with an uppercase even though it's in the middle of a sentence.

CommentFileSizeAuthor
#7 2902818-7.patch9.22 KBnikunjkotecha
#2 grammatical_error_in-2902818-2.patch2.45 KBLeon Kessler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Leon Kessler created an issue. See original summary.

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
Status: Active » Needs review
FileSize
grammatical_error_in-2902818-2.patch2.45 KB

Status: Needs review » Needs work

The last submitted patch, 2: grammatical_error_in-2902818-2.patch, failed testing. View results

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
Status: Needs work » Needs review

Switching back to needs review as issue in test is something unrelated.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and at Axelerant commented
Status: Needs review » Postponed (maintainer needs more info)

Not really good with grammar but looks like we are trying to change the field's label value here in code.

Also, current code is consistent with 7.x
http://cgit.drupalcode.org/clientside_validation/tree/plugins/validator/...

I feel we should aim at allowing these messages to be configurable. What do you say @Leon / @Jelle_S / @attiks?

hocu’s picture

hocu CreditAttribution: hocu commented

An option could be surrounding them with quotes.

@nikunjkotecha I think messages definitely need to be configurable. Those are very generic. Configuring them for some specific use case would help the site builders a lot.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented
Issue tags: +Needs tests
FileSize
2902818-7.patch9.22 KB

Updated all the plugins to allow overriding the message. Need Tests to be updated for same.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented
Status: Postponed (maintainer needs more info) » Needs review
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented

@hocu I assume this patch fixes your issue https://www.drupal.org/project/clientside_validation/issues/3048775

Would love to hear your feedback (or at-least one feedback) on this before I merge it and release new version

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented
Related issues: +#3048775: Issue with 'max' attribute validation message
hocu’s picture

hocu CreditAttribution: hocu commented

@nikunjkotecha I'm testing it and I'll inform you about the results. I was planning to write a quick patch for the other issue but your solution seems to be more thorough. Thanks.

hocu’s picture

hocu CreditAttribution: hocu commented
Status: Needs review » Reviewed & tested by the community

I've tested this and I can confirm that it's working. This also helped me override the messages via another module. So issue #3048775 is also solved.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented

thanks, I'll merge now and release as IMO this is major milestone, about tests I'll be reworking them anyways to get it work with D9, I'll keep this ticket open to remind me about that.

  • nikunjkotecha committed f27477a on 8.x-1.x 
    Issue #2902818 by nikunjkotecha, Leon Kessler, hocu: Grammatical error...
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented

https://www.drupal.org/project/clientside_validation/releases/8.x-1.1

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
CreditAttribution: nikunjkotecha as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.