Problem/Motivation

I was adding the clamav service to a custom module with dependency injection and noticed the ScannerInterface class isn't implemented by the Scanner class. So my service inject failed.

Steps to reproduce

Try to use clamav service with dependency injection.

Proposed resolution

Mark the class as implementing that interface.

User interface changes

None

API changes

Scanner will be an implementation of ScannerInterface

Issue fork clamav-3403522

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

minorOffense created an issue. See original summary.

minorOffense opened merge request !8

minoroffense’s picture

minoroffense commented
Status: Active » Needs review
solideogloria’s picture

solideogloria commented
Assigned: Unassigned » solideogloria
Status: Needs review » Needs work

I have a couple small things to add, such as {@inheritdoc}. I ran out of time to commit it, but I'll try to get it in on Monday.

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
solideogloria’s picture

solideogloria commented
Assigned: solideogloria » Unassigned
solideogloria’s picture

solideogloria commented
Related issues: +#3017006: Coding Standards

Adding related issue, because there might be merge conflicts.

jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

tested and works as required

vladimiraus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution. 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.