Needs review
Project:
CKEditor Link
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Sep 2017 at 08:17 UTC
Updated:
20 Sep 2017 at 08:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pacproduct commentedI tried patching the module but I must say I'm a bit confused and I'm not sure to fully understand how the module has been designed... I hope someone else will be able to enlighten me :)
My understanding is that ckeditor_link is designed to insert technical links only into the HTML, so that they get converted to their aliased and internationalized links when displaying the node.
That is where the
hook_ckeditor_link_TYPE_url()hook comes in, making this conversion possible.Is that correct?
I added this hook to the existing plugin
ckeditor_link.i18n_menu.incas follows (see attached patch):Now the behavior I described in the initial post is slightly better, even though not entirely satisfactory in my opinion. Here is how it works with this added hook:
This is still counter-intuitive even though on a technical level I kind of understand that it means the link should target the French version of the technical link "/projects".
Any insight on this?
Any better idea on how to improve this? :)
Note: Patch and code retested against 7.x-2.x-dev this time.
Comment #3
pacproduct commentedComment #4
simon georges commented