Problem/Motivation

When inserting a grid for the first time, the current default option is "None (advanced)" which does not insert any column classes. It could be argued that if a content editor is using the grid functionality they at least are looking for some sort of column classes.

Current default layout.

Steps to reproduce

Insert new grid.

Proposed resolution

It would be ideal to default to "Equal Width" for most cases.

CommentFileSizeAuthor
#6 3208113-allow-default.patch10.46 KBb_sharpe
#3 ckeditor_bs_grid-default_equal_width-3208113-3.patch607 byteschrissnyder
Selection_999(1448).png32.94 KBchrissnyder

Issue fork ckeditor_bs_grid-3208113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrissnyder created an issue. See original summary.

chrissnyder opened merge request !4

chrissnyder’s picture

chrissnyder
he/him
commented
Status: Active » Needs review
StatusFileSize
new ckeditor_bs_grid-default_equal_width-3208113-3.patch607 bytes

Corresponding patch file

b_sharpe’s picture

b_sharpe commented
Status: Needs review » Needs work

I think this is a great idea, but I think it should be configurable as a default.

I'm going to delay this at the moment in favor of #3193368: Allow Layout Configuration Then once you can configure the layouts, we can also have a configurable set of defaults.

b_sharpe’s picture

b_sharpe commented

This can now be achieved in 2.0.x; however, it is done by making the first option your default and I feel might be better served by allowing an actual "default". Setting to needs work.

b_sharpe’s picture

b_sharpe commented
Status: Needs work » Needs review
StatusFileSize
new 3208113-allow-default.patch10.46 KB

Adds patch for table drag that allows default settings.

gordonio’s picture

gordonio commented
Status: Needs review » Reviewed & tested by the community

  • b_sharpe committed 351ef76 on 2.0.x 
    Issue #3208113 by chrissnyder, b_sharpe, gordon.vollo: Default to Equal...
b_sharpe’s picture

b_sharpe commented
Status: Reviewed & tested by the community » Fixed

Thanks both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.