Problem/Motivation

In order to improve the module maintainability it would be great to add CI tools to guarantee that coding standards are respected.

Steps to reproduce

Proposed resolution

Remaining tasks

  • Add a .gitlab-ci.yml

User interface changes

API changes

Data model changes

Issue fork ckeditor5_inline_quote-3511025

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

macsim created an issue. See original summary.

macsim opened merge request !1

macsim’s picture

macsim commented
Assigned: macsim » Unassigned
Status: Active » Reviewed & tested by the community

Gitlab CI is now enabled on the merge request : https://git.drupalcode.org/project/ckeditor5_inline_quote/-/merge_reques...
After this will be merged on 1.0.x, coding standards will run on every branch and each commit.

The fact that CI pipelines are running on gitlab is enough to set that issue to RTBC.
New issues tickets should be created to fix errors and warnings reported by the CI tools when this will be merged.

  • macsim authored 6d6088f2 on 1.0.x 
    Issue #3511025 by macsim: Add CI tools
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

@macsim thanks for your contribution!

Now, feel free to fix the pipeline warnings ;)

macsim’s picture

macsim commented
Status: Fixed » Closed (fixed)