Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
As identified in #3211049-5: [META] Add all plugins which are available in Drupal core's build of CKEditor 4.1: we do not have a "remove formatting" button currently in the Drupal CKEditor 5 module. This is valuable when cleaning up pasted content. See demo at https://ckeditor.com/docs/ckeditor5/latest/features/remove-format.html#demo.
Proposed resolution
Add https://github.com/ckeditor/ckeditor5/tree/master/packages/ckeditor5-rem... to our build.
Remaining tasks
- Add remove-format plugin to js/scripts/build.js
- Create library for the plugin in ckeditor5.libraries.yml
- Create plugin definition for the plugin in ckeditor5.ckeditor5.yml
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#17 | drupal-changes_in_expected-3227875-17.patch | 1.25 KB | yash.rode |
#14 | Drupal-mapping_changes-3227875-14.patch | 790 bytes | yash.rode |
#13 | Drupal-mapping-3227875-12.patch | 790 bytes | yash.rode |
#12 | --mapping.patch | 0 bytes | yash.rode |
Issue fork ckeditor5-3227875
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Wim Leers🙈
Is it clear I copy/pasted this from #3227871: Add ckeditor5-paste-from-office to allow pasting from Microsoft Office & Google Docs? 😁
Comment #3
lauriiiComment #6
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #7
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #9
lauriiiTested this manually to ensure that the button can be added to toolbar, and formatting can be removed from text. All looks good now!
Comment #10
Wim LeersNice! :)
Comment #11
Wim LeersCan we add a second merge request to this issue so we can also update
\Drupal\ckeditor5\SmartDefaultSettings::mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem()
's mapping forRemoveFormat
? 🙏Comment #12
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #13
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #14
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #16
Wim LeersPerfect! Now all we need to do is update the test expectations 😊
Comment #17
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #18
yash.rode CreditAttribution: yash.rode at Acquia commentedComment #19
Wim LeersPerfect! Thanks 😊
Comment #21
Wim Leers