Closed (fixed)
Project:
CKEditor 5
Version:
1.0.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 May 2021 at 10:45 UTC
Updated:
28 Jul 2021 at 13:54 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #2
wim leers👍
Thanks for creating this!
Also tagging to make clear this is blocked on an upstream feature, not on us.
Comment #3
wim leersWe've been told that the CKEditor team will ship a preview version of this by the end of June! 🤞🥳
Comment #5
lauriiiThe general HTML support will be available on a release later this week. However, I made some progress on this based on CKE master branch.
Comment #6
wim leersI see that the draft PR is not yet rebased against
1.0.x, which includes #3201637: Figure out how to prevent data loss during upgrade/migration path. Posting the patch here that removes the protection against arbitrary HTML support that #3201637: Figure out how to prevent data loss during upgrade/migration path added, and conditionally enables GHS.Note that
\Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5AllowedTagsTest::testEnablingToVersion5Validation()will fail. That's because this issue/MR will need to update that test coverage.Comment #7
wim leersComment #8
wim leersThis blocks #3222842: <a hreflang> + <blockquote cite>.
Comment #9
wim leersWith that last commit that I pushed, I was able to enable this on a new text format with zero text filters … 🥳
… and in doing so I was able to do this:
Nice!
I'll test this in more detail on Monday.
Comment #10
wim leersThe 3 remaining test failures should be pretty doable to fix — but unfortunately this first and foremost needa a rebase now that #3222327: Add CI testing that reuses Drupal core's `commit-code-check.sh` script landed 😅😬
Comment #11
wim leersComment #12
wim leers#3222982: Follow-up for #3222327: cspell inspecting contents of generated JS files landed, that should make this green except for
which will need a
cspell:ignorecomment.Comment #13
lauriiiComment #14
wim leersThis works beautifully for the use case but is in need of expanded test coverage 😅🙏
Comment #16
bnjmnmI began work on the requested test, but can't finish at the moment. There is a @todo describing where I left off if someone else wants to resume work on it before I can return to it.
Comment #17
lauriiiTests are now part of the MR
Comment #18
wim leersWill review in the morning — exciting! 🥳
Comment #19
wim leersMaking the issue title more precise to match the actual scope.
Using GHS in other aspects is out of scope here. We actually have concrete issues already for those: see many of the child issues of #3222801: [META] Ensure CKE5 equivalent plugins of CKE4 generate/support equivalent markup. For example: #3222842: <a hreflang> + <blockquote cite>.
As soon as tests pass here, I think this is ready to go.
Comment #21
lauriiiThank you! 🙏