Additional tokens in styles_path and css_path for sites with same codebase. Better features support. [#2713419]

Hi everybody,

I'm working on several multi sites with the same CKEditor profile, and shared featured but different paths for editor styles and editor.css. Depending on conditions (e.g. domain or theme) I needed additional tokens.

Therefore I have created a patch with several hooks to support this new feature and implemented the hook to provide current functionality.

Instead of the current:
%h - host
%t - theme
%m - module

You can extend or alter these tokens with e.g.:
%site - site config path
%activetheme - current active theme
%domaintheme - current domains theme

Please review my work and let me know this functionality is interesting for the ckeditor module or code improvements are needed.

Thanks!

Cheers,

Eric

Comment	File	Size	Author
#12	ckeditor-style-css-tokens-2713419-9-7.x-1.x-dev.patch	8.24 KB	ericclaeren
#12	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error PHP 5.6 & MySQL 5.5, D7 2 pass
#9	ckeditor-style-css-tokens-2713419-8-7.x-1.x-dev.patch	8.35 KB	ericclaeren
#9	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error
#2	ckeditor-style-css-tokens-2713419-7.x-1.x-dev.patch	7.63 KB	ericclaeren
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 2 pass PHP 5.3 & MySQL 5.5, D7 CI error PHP 5.6 & MySQL 5.5, D7 CI error PHP 5.4 & MySQL 5.5, D7 2 pass PHP 5.5 & MySQL 5.5, D7 2 pass PHP 5.6 & MySQL 5.5, D7 2 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

26 April 2016 at 09:18

ericclaeren created an issue. See original summary.

Comment #2

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 26 April 2016 at 09:19

File	Size
ckeditor-style-css-tokens-2713419-7.x-1.x-dev.patch	7.63 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 2 pass PHP 5.3 & MySQL 5.5, D7 CI error PHP 5.6 & MySQL 5.5, D7 CI error PHP 5.4 & MySQL 5.5, D7 2 pass PHP 5.5 & MySQL 5.5, D7 2 pass PHP 5.6 & MySQL 5.5, D7 2 pass

Comment #3

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 26 April 2016 at 09:20

Issue summary:

View changes

Comment #4

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 26 April 2016 at 09:20

Issue summary:

View changes

Comment #5

26 April 2016 at 09:21

Status:

Needs review

» Needs work

The last submitted patch, 2: ckeditor-style-css-tokens-2713419-7.x-1.x-dev.patch, failed testing.

Comment #6

26 April 2016 at 10:09

The last submitted patch, 2: ckeditor-style-css-tokens-2713419-7.x-1.x-dev.patch, failed testing.

Comment #7

rudiedirkx CreditAttribution: rudiedirkx commented 27 April 2016 at 22:09

Invalid HTML: </br>
Usually, hook_x_alter alters the 'raw' information from hook_x, not the semi-processed information
What does this mean?: "Keys are filtered by alpha numeric, array key: Key_1 will result in token %key1." << That last doesn't seem to be true...
It's very useful if api.php mentions specifically what's inside $context, maybe in a sub list in the comment, with descriptions.

This is a great addition! %h is always too broad, and %t is usually too specific. Maybe ckeditor could add %s (e.g. /sites/mysite/) as a token by default too? It's in between %h and %t specificity-wise.

Comment #8

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 17 May 2016 at 08:18

Status:

Needs work

» Needs review

Comment #9

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 17 May 2016 at 08:19

File	Size
ckeditor-style-css-tokens-2713419-8-7.x-1.x-dev.patch	8.35 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error

Comment #10

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 17 May 2016 at 08:19

1 file was hidden/shown/deleted

File	Size
ckeditor-style-css-tokens-2713419-8-7.x-1.x-dev.patch	8.35 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error

Comment #11

17 May 2016 at 08:22

Status:

Needs review

» Needs work

The last submitted patch, 9: ckeditor-style-css-tokens-2713419-8-7.x-1.x-dev.patch, failed testing.

Comment #12

ericclaeren CreditAttribution: ericclaeren at ezCompany commented 17 May 2016 at 08:43

Status:

Needs work

» Needs review

File	Size
ckeditor-style-css-tokens-2713419-9-7.x-1.x-dev.patch	8.24 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error PHP 5.6 & MySQL 5.5, D7 2 pass

Damn uploaded the wrong patch, this is the correct one.

Comment #13

17 May 2016 at 08:45

Status:

Needs review

» Needs work

The last submitted patch, 12: ckeditor-style-css-tokens-2713419-9-7.x-1.x-dev.patch, failed testing.

Comment #14

rudiedirkx CreditAttribution: rudiedirkx commented 15 March 2017 at 18:02

Status:

Needs work

» Needs review

Maybe tests?

Comment #15

rudiedirkx CreditAttribution: rudiedirkx commented 15 March 2017 at 18:37

Status:

Needs review

» Reviewed & tested by the community

https://www.drupal.org/pift-ci-job/622798 passed, and I've tried it, and I like it. %s is SO valuable!

Comment #16

jcisio CreditAttribution: jcisio at Axess Open Web Services commented 23 June 2017 at 13:38

Status:

Reviewed & tested by the community

» Needs work

Thanks, it's a reasonable add-on. I've only done a quick review:
- Coding standards: unneeded empty trailing lines in docblocks, each sentence should end with ".", comments are wrapped at 80 characters but not before.
- Some copy/paste leftover: $context of hook_ckeditor_path_tokens_alter().
- The array keys are without "%" in the hook, but with "%" in the alter hook, which leads to confusion. I'd suggest add "%" prefix everywhere and do not force it (so a token could be without "%" prefix, it may use another prefix or no prefix at all).