Hello

I got problem. Toolbar in ckeditor profile is not saved for me. Seems it's occured because toolbar is textarea but ckeditor set value of toolbar as

.attr('value', value);

It will work for input with type text, but not for textarea.
It should be:

.val(value);

CommentFileSizeAuthor
#1 2324383-Toolbar_in_Ckeditor_profile_is_not_saved-1.patch1.12 KBeugene.ilyin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Active » Needs review
FileSize
2324383-Toolbar_in_Ckeditor_profile_is_not_saved-1.patch1.12 KB

I prepared patch to solve this problem

Helrunar’s picture

Helrunar CreditAttribution: Helrunar commented
Status: Needs review » Needs work

Patch is not working for me.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

What the problem?

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented
Status: Needs work » Needs review
Helrunar’s picture

Helrunar CreditAttribution: Helrunar commented

After aplying the Patch i am also not able to save the modified profil. I want to remove some Buttons, save and nothing is happend.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Strange. Which version of CKeditor do you use? Maybe you have js errors?

Helrunar’s picture

Helrunar CreditAttribution: Helrunar commented

I am using Version 7.x-1.5 and CKEditor 4.4.3. Thats crazy, now it save my changes. I will test it in another installation again.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Drupal magic ;) Can anybody test this patch?

Helrunar’s picture

Helrunar CreditAttribution: Helrunar commented

Ok, it's seems to be a problem with jQuery1.10. When i switch back to jQuery1.7 all work fine. Tested on a new and clean installation.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Needs review » Reviewed & tested by the community

Technically, this is a duplicate of an earlier issue #2275691: CKEditor 1.14: in "Editor appearance" the Current toolbar can not be changed, however, this issue has a patch AND the patch works.

In addition to the patch working, its actually best practices to use jQuery .val('somevalue') instead of .attr('value', 'somevalue'), so marking this RTBC, as it needs to go in, regardless of whether this does or does not solve the toolbar problem for others. ;)

jcisio’s picture

jcisio CreditAttribution: jcisio commented
Title: Toolbar in Ckeditor profile is not saved » Toolbar in Ckeditor profile is not saved: incompatibility with jQuery 1.10
Status: Reviewed & tested by the community » Needs review

Do people test with jQuery 1.4.4 (the one shipped with core), 1.7 and 1.10?

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin commented

Do people test with jQuery 1.4.4 (the one shipped with core), 1.7 and 1.10?

Bug, which I described is reproduced for me only with jQuery 1.10.

I added patch and it works correctly for jQuery 1.4.4, 1.7 and 1.10

jcisio’s picture

jcisio CreditAttribution: jcisio commented
Status: Needs review » Fixed

Committed and pushed. Thanks!

  • jcisio committed a1f89be on 7.x-1.x authored by eugene.ilyin 
    Issue #2324383 by eugene.ilyin: Toolbar in Ckeditor profile is not saved...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan commented

In case anyone is searching for the error message, it's "Enter a valid toolbar configuration".

kenorb’s picture

kenorb CreditAttribution: kenorb commented
Related issues: +#2330283: Cannot add plugins buttons to editor configuration, and configured plugins buttons do not appear