Problem/Motivation

1. Limiting the amount of code on the server is a good practice for security
2. The storybook is rarely accessed via theme settings after development
3. Storybook also causes a lot of git conflict issues when merging in a GovCMS SaaS workflow taking up time to resolve
3. Adding a .gitignore to not add the static storybook to repository

Proposed resolution

1. Update theme settings not to show a section for storybook
2. Adding .gitignore not to add the storybook static build to the code repository in subtheme builder template

CommentFileSizeAuthor
#12 storybook source.png865.49 KBdanielgry
#12 storybook removal.png213.48 KBdanielgry

Comments

richardgaunt created an issue. See original summary.

fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.10

richardgaunt credited joshua1234511.

richardgaunt’s picture

richardgaunt commented

https://github.com/civictheme/monorepo-drupal/pull/1331
PR ready for review

richardgaunt’s picture

richardgaunt commented
richardgaunt’s picture

richardgaunt commented
Status: Active » Needs review
richardgaunt’s picture

richardgaunt commented

Implemented with:
https://github.com/civictheme/uikit/pull/477

  • b0dfc2b1 committed on 1.x 
    Issue #3504424 by richardgaunt, joshua1234511: Remove storybook from...
fionamorrison23’s picture

fionamorrison23 commented
Assigned: richardgaunt » danielgry

fionamorrison23 credited danielgry.

fionamorrison23’s picture

fionamorrison23 commented
danielgry’s picture

danielgry commented
StatusFileSize
new storybook removal.png213.48 KB
new storybook source.png865.49 KB

Verified and tested on 1.x-dev

Testing Results:
1. Storybook section is no longer visible in theme settings
2. storybook-static files are not present
3. storybook-static is expectedly present in .gitignore

Screenshot:

danielgry’s picture

danielgry commented
Assigned: danielgry » richardgaunt
Status: Needs review » Reviewed & tested by the community
richardgaunt’s picture

richardgaunt commented
Version: 1.9.0 » 1.10.0
Status: Reviewed & tested by the community » Fixed
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.10.0 » 1.9.0
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.9.0 » 1.10.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.