Was looking to get PATCH support included.

It's currently a @todo in the _chr_curl_request_type_option function.

The following seems to work ok for me:

    case 'PATCH':
      curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'PATCH'); 
      curl_setopt($ch, CURLOPT_POSTFIELDS, $options['data']);     
      $valid_method = TRUE;

I'll look at attaching this as a patch.

CommentFileSizeAuthor
#7 chr-patch-support-2406891-7.patch472 bytesjonathan webb
#1 chr-patch-support-2406891-1.patch504 bytesmaikeru

Comments

maikeru’s picture

maikeru commented
StatusFileSize
new chr-patch-support-2406891-1.patch504 bytes
kenorb’s picture

kenorb commented
Status: Active » Needs review
leducdubleuet’s picture

leducdubleuet commented
Status: Needs review » Reviewed & tested by the community

I can confirm this patch works great to implement the PATCH method.

Thanks @maikeru!

leducdubleuet’s picture

leducdubleuet commented

Would it be possible to have this patch committed for the next release please?

fool2’s picture

fool2 commented

+1 It would be nice to be able to use chr as a dependency with this included.

fuerst’s picture

fuerst commented

Thanks a lot for the patch! Works as expected and really needed.

jonathan webb’s picture

jonathan webb commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new chr-patch-support-2406891-7.patch472 bytes

The code in the patch from maikeru works, but changes the mode of chr.module. I've uploaded an updated patch to remove that mode change.

leducdubleuet’s picture

leducdubleuet commented
Status: Needs review » Reviewed & tested by the community

Thanks RTBC

jibus’s picture

jibus commented

Thank you ! Works as expected.

Drupal 7 will become EOL in 2025. Still can someone commit this ?