Use tagged version of library in make -- at least for tagged releases? [#2021641]

As #2021639: Chosen directory renamed to public from chosen, js cannot be added illustrates, using the head of chosen can break a site even when using the current tagged release of chosen module, so at least for tagged versions it'd be useful to use tagged version of chosen library,

Comment	File	Size	Author
#4	specified_library_version-2021641-4.patch	338 bytes	timmarwick
#4
#3	2021641-3-7x-1x-specified-library-version.patch	442 bytes	smithmilner
#3
#2	2021641-2-7x-1x-specified-library-version.patch	441 bytes	smithmilner
#2
	chosen-use-tag-version.patch	304 bytes	hefox

Comments

girishmuraly CreditAttribution: girishmuraly commented 19 June 2013 at 16:56

I agree - we should use tagged version. The patch works for me.

smithmilner CreditAttribution: smithmilner commented 20 June 2013 at 20:27

File	Size
2021641-2-7x-1x-specified-library-version.patch	441 bytes

Here is a specified version for the 1.x branch

smithmilner CreditAttribution: smithmilner commented 20 June 2013 at 20:51

File	Size
2021641-3-7x-1x-specified-library-version.patch	442 bytes

Oops, due to the way git sorts tags I didn't see the newest one. This patch specifies the v0.9.15 tag for the 1.x branch.

timmarwick CreditAttribution: timmarwick commented 27 June 2013 at 01:04

File	Size
specified_library_version-2021641-4.patch	338 bytes

Patch does not apply. Here is one that does.

girishmuraly CreditAttribution: girishmuraly commented 27 June 2013 at 13:16

@Timothy can you confirm you are trying on 1.x branch and the patch from #3?

So as to not confuse readers, the patch in #0 applies cleanly (at least for me) on the 2.x branch, for which this issue is on.

Can someone kindly confirm the patch for 2.x version, then mark this issue for 1.x and associate patch for that?

favrik CreditAttribution: favrik commented 3 July 2013 at 08:28

Patch #0 works for me too on version 2.x.

girishmuraly CreditAttribution: girishmuraly commented 3 July 2013 at 09:08

Status:

Active

» Reviewed & tested by the community

Hydra CreditAttribution: Hydra commented 31 July 2013 at 19:23

Status:

Reviewed & tested by the community

» Closed (fixed)

Well, thanks for working on this. I committed a version of #2021639: Chosen directory renamed to public from chosen, js cannot be added with the new 1.0 release of chosen, this should be working now. The trick is to use the release version, not the development version :)