Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new524 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0

andileco’s picture

Issue summary: View changes
Status: Needs review » Active
immaculatexavier’s picture

StatusFileSize
new50.59 KB
new792.54 KB

Reviewed the patch:
1 Downloaded and installed the "Project Update Bot" patch - #2.
2. Examined the module based on Upgrade Status
3. 15 warning were discovered in the Upgrade Status report.
Conclusion : #2 patch seems to be D10 compatible module.
Despite the fact that the following 15 warnings were discovered.
charts

immaculatexavier’s picture

Issue tags: +Drupal 10 porting day
immaculatexavier’s picture

Status: Active » Needs work
mradcliffe’s picture

Status: Needs work » Needs review
StatusFileSize
new3.33 KB

Hi @immaculatexavier, thank you for analyzing the module. Remember to install all the sub-modules prior to analyzing upgrade_status.

I confirm the following results only in the sub-modules, but not the library issues:

File name Line Error
web/modules/contrib/charts/modules/charts_api_example/charts_api_example.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/charts/modules/charts_billboard/charts_billboard.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/charts/modules/charts_blocks/charts_blocks.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/charts/modules/charts_c3/charts_c3.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/charts/modules/charts_chartjs/charts_chartjs.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/charts/modules/charts_google/charts_google.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..
web/modules/contrib/charts/modules/charts_highcharts/charts_highcharts.info.yml 0 Value of core_version_requirement: ^9.2 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687..

Once patched, I did not find any further results.

aarti zikre’s picture

reviewing this

aarti zikre’s picture

Assigned: Unassigned » aarti zikre
aarti zikre’s picture

Status: Needs review » Needs work
StatusFileSize
new69 KB
new76.13 KB

Verified on d9

Testing step:
*Install all the module of charts
* enable them
* run the upgrade status

It shows two warnings.

Reference ss
Module list:
module list_0.png

Warnings:
2022-07-29/after patch_0.png

aarti zikre’s picture

Assigned: aarti zikre » Unassigned
mradcliffe’s picture

Status: Needs work » Needs review

Setting back to needs review.

I tried to replicate your steps, @aaron_zikra, but was unable to do so.

It looks like you have installed charts 5.0.1 and not the 5.0.x-dev version that has the most recent commit. After you install that version, then you can apply the patch to resolve compatibility.

Additionally upgrade_status will not be able to check the charts_api_example module because you do not have that module installed. Once you install that module, upgrade_status will check compatibliity.

  • andileco committed 7ce1e97 on 5.0.x authored by mradcliffe
    Issue #3286450 by Project Update Bot, mradcliffe, aarti zikre,...
andileco’s picture

Status: Needs review » Active

Thanks, folks! I have committed the updates to the .info.yml files (the other issues were from needing to enable all the submodules). I'm switching this back to active in order to receive any additional updates from the bot.

kristen pol’s picture

Thanks everyone for participating in porting day! And thanks for committing the latest patch @andileco :) (and explaining the reason the issue is back to Active as that has been unclear for some people)

nikathone’s picture

Status: Active » Needs review
StatusFileSize
new1.32 KB

Adding a patch related to app.root and site.path services have been converted to container parameters.

At the moment if you try to create a chart on drupal 10 the chart won't display but after applying this path it will start to work again.

  • andileco committed 6286cce on 5.0.x authored by nikathone
    Issue #3286450 by nikathone, andileco: Automated Drupal 10 compatibility...
andileco’s picture

Status: Needs review » Active

Thank you, @nikathone - committed and moving back to "active" to receive additional updates from the bot.

zarabatana’s picture

This patch adds the remaining points for full Drupal 19 compatibility.

andileco’s picture

Status: Active » Needs review
andileco’s picture

Status: Needs review » Active

@zarabatana, I believe everything in your patch is already committed to 5.0.x. Were you just adding the patch so you wouldn't need to require the dev branch?

zarabatana’s picture

Yes, waiting for a new release to not have to patch anymore.
Thanks in advance @andileco

project update bot’s picture

Issue summary: View changes
bluegeek9’s picture

Issue summary: View changes
Status: Active » Closed (duplicate)
Related issues: +#3428350: Automated Drupal 11 compatibility fixes for charts