We should make it so people can build Charts in Twig.

CommentFileSizeAuthor
#2 render-charts-twig-3179958-2.patch2.97 KBandileco
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andileco created an issue. See original summary.

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Status: Active » Needs review
FileSize
render-charts-twig-3179958-2.patch2.97 KB

First attempt. Works, but doesn't have all the features, and hasn't updated the API document.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

cool! haven't tried it , we're using 8.x-3.x not 5.0.x

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Status: Needs review » Closed (works as designed)

I'm going to create a separate module for this feature.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

Ah you're the maintainer so you have the final say, it looks great from what I can see so far.

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

Here's the new module. Definitely encourage you to upgrade to 5.0.x to take advantage of this!

https://www.drupal.org/project/charts_twig

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

cool I starred it, thanks!