Before this module moves to beta, I'd like most of the code documentation issues as shown in https://pareview.sh/node/1430 to be fixed.

CommentFileSizeAuthor
#29 charts-2879533-29.patch15.82 KBlbaran
#26 charts-2879533-26.patch20.69 KBlbaran
#24 charts-2879533-24.patch11.73 KBlbaran
#21 charts-2879533-21.patch13.53 KBlbaran
#17 charts-2879533-17.patch81.13 KBlbaran
#15 charts-2879533-15.patch69.1 KBlbaran
#12 charts-2879533-12.patch91.71 KBlbaran
#4 charts-2879533-4.patch86.4 KBlbaran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andileco created an issue. See original summary.

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Category: Support request » Task
andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Issue tags: +DrupalGovCon
lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-4.patch86.4 KB

Hi andileco,

I have a first patch to fix this issue.

Sincerely,

  • andileco committed e1d1f83 on 8.x-3.x 
    Issue #2879533 by lbaran: Improve Charts code documentation
andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

OK, please test!

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Status: Active » Postponed

Actually, please wait to continue this one. I want to commit another issue before continuing on this issue: https://www.drupal.org/project/charts/issues/2928419

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
mwebaze’s picture

mwebaze CreditAttribution: mwebaze at JSI Research & Training Institute, Inc. (JSI) commented

Hi @andilco and Ibaran,

is this patch(es) part of the 8.x-3.x branch?

Regards,

Michael

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

Yes, it was committed to 8.x-3.x-dev

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Status: Postponed » Active

OK, active again!

lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-12.patch91.71 KB

Hi andileco,

I have a new patch and I still continue to correct the issue.

Sincerely,

  • andileco committed 350cdc2 on 8.x-3.x 
    Issue #2879533 by lbaran: Improve Charts code documentation
andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

Thank you! Patch 12 was committed.

lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-15.patch69.1 KB

Hi andileco,

I have a new patch and I think it will be the penultimate patch.

Regards,

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

Hi @lbaran, this patch introduces an issue with Google Charts:

Error: Class 'Drupal\charts_google\Plugin\chart\VerticalAxis' not found in Drupal\charts_google\Plugin\chart\GoogleCharts->createChartsOptions() (line 97 of /app/modules/contrib/charts/modules/charts_google/src/Plugin/chart/GoogleCharts.php) #0 /app/modules/contrib/charts/modules/charts_google/src/Plugin/chart/GoogleCharts.php(67): Drupal\charts_google\Plugin\chart\GoogleCharts->createChartsOptions(Array, Array, Array) #1 /app/modules/contrib/charts/charts.module(107): Drupal\charts_google\Plugin\chart\GoogleCharts->buildVariables(Array, Array, Array, Array, Array, 'money_awarded_i...')

It's related to the two axis classes being combined into one (if you combine into one, please name it ChartAxes instead of ChartAxis, since it includes both X and Y).

Thanks!

lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-17.patch81.13 KB

Sorry andileco,

I corrected ChartAxis in ChartAxes.

  • andileco committed 5a0e507 on 8.x-3.x 
    Issue #2879533 by lbaran: Improve Charts code documentation
andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

Made an edit to line 97 and committed.

lbaran’s picture

lbaran CreditAttribution: lbaran commented

Thanks andileco.

lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-21.patch13.53 KB

Hi andileco,

I have a new patch.

Regards,

  • andileco committed 78d6fcf on 8.x-3.x 
    Issue #2879533 by lbaran: Improve Charts code documentation
andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

OK, committed.

lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-24.patch11.73 KB

Hi andileco,

I have a new patch.
As the website https://pareview.sh/ does not work, I will continue with the Coder project.

Regards,

lbaran’s picture

lbaran CreditAttribution: lbaran commented
lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-26.patch20.69 KB

Patch #26 should be used instead of 24.

  • andileco committed a2b396d on 8.x-3.x authored by lbaran 
    Issue #2879533 by lbaran, andileco: Improve Charts code documentation
andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented

Took out the composer.lock files, otherwise, committed.

lbaran’s picture

lbaran CreditAttribution: lbaran commented
FileSize
charts-2879533-29.patch15.82 KB

Its good. I deleted the "composer.lock" files in the new patch.

andileco’s picture

andileco CreditAttribution: andileco at JSI Research & Training Institute, Inc. (JSI) commented
Status: Active » Closed (outdated)