Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When creating a view with chart blocks and pages, users are forced to use the view name as the title of each chart. This means that you need to create a new view for specifically for each chart. I've fixed it so that it uses the display title instead. This means that users can create multiple blocks/displays within a view and they can all have different chart titles. This also allows users to leave the title out by leaving the display title empty.
Comment | File | Size | Author |
---|---|---|---|
#1 | chart-1994968-1.patch | 795 bytes | zhuber |
Comments
Comment #1
zhuber CreditAttribution: zhuber commentedPlease test and commit this patch whenever you get a chance.
Thank you.
Comment #2
zhuber CreditAttribution: zhuber commentedComment #3
namwebs CreditAttribution: namwebs commentedThanks, it worked for me.
Comment #4
zhuber CreditAttribution: zhuber commentedComment #5
13rac1 CreditAttribution: 13rac1 commentedPlease don't set "Patch" unless it is already committed to a different branch:
Patch (to be ported)
The patch has been successfully committed to a branch of the project, and still needs to be committed to another, but the current patch doesn't apply to the target branch and needs to be modified in order to do so.
Comment #6
zhuber CreditAttribution: zhuber commentedUnderstood.
Any chance we can get this patch review/tested? I'd like to get this committed to the module so we don't have a large amount of people using hacked modules in order to achieve this functionality.
Comment #7
Pierre.Vriens CreditAttribution: Pierre.Vriens commented+1 for #6 ... anybody of the +25K sites using chart that can help reach status "tested by community"? Or is #3 sufficient for me to do so (personally I think so ...)?
Note the parent link I'm adding already ...
Comment #8
Pierre.Vriens CreditAttribution: Pierre.Vriens commentedUnless this issue becomes "tested by community" ASAP, it won't make it into the 7.x-1.2 Release (to not put that release at risk). If it still gets tested "on time", it should be included I think. But "on time" now means "in the coming hours/days" ...
Comment #9
jtsnow CreditAttribution: jtsnow commentedThis looks like a good change, but it assumes that people have entered sensible display titles. It's possible that someone has entered a view name of "2013 Profits" and a display title such as "Test Chart 3". I'd think that a friendly note in the changelog reminding people to check display titles would suffice.