Yesterday, @gabesullice pointed out that you can use a service as a controller in Drupal 8. (See https://www.drupal.org/docs/8/api/routing-system/structure-of-routes)

Which means there's no need for CdnFarfutureController to implement ContainerInjectionInterface. We can just make it a service.

Let's do that. One less bit of brittleness.

CommentFileSizeAuthor
#7 2935895-7-cs_followup.patch698 bytesWim Leers
#2 2935895-2.patch2.2 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Status: Active » Needs review
FileSize
2935895-2.patch2.2 KB
gabesullice’s picture

gabesullice
Primary language English
CreditAttribution: gabesullice commented

😗👌

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer and at Acquia commented

😀

  • Wim Leers committed 9ebca8f on 8.x-3.x 
    Issue #2935895 by Wim Leers, gabesullice: Use a service as a controller...
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer and at Acquia commented
Status: Needs review » Fixed
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer and at Acquia commented
FileSize
2935895-7-cs_followup.patch698 bytes

Oops.

  • Wim Leers committed e66af93 on 8.x-3.x 
    Issue #2935895 by Wim Leers, gabesullice: (follow-up) Forgot to remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.