Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.As the topic suggests if you have more than one field the Javascript conditional doesn't work at all on the second field in the list.
I'll need to write a test for this.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 801382.patch | 2.15 KB | mradcliffe |
| #3 | cck_select_other.patch | 3.68 KB | altrugon |
| #1 | cck_select_other-multiple.patch | 4.33 KB | mradcliffe |
Comments
Comment #1
mradcliffeProbably won't be able to write a test for this, but it passes all current tests.
Comment #2
mradcliffeCommitted.
Comment #3
altrugon commentedHi there,
I run your patch but I still found errors with the field names. The current field names were using underscore (php format) and not dashes and Drupal likes it for Javascript and CSS.
The attached patch fix the problem and still preserve the changes that you made.
Comment #4
altrugon commented@mradcliffe I just noticed that while I was writing this post your patch got committed, I'm not sure if this will be a problem applying my patch. Just in case all the changes that I did were in cck_select_other.js file.
Comment #5
mradcliffeThank you for the fixes. I'm not much of a javascript expert.
I've merged the changes in, and I like your change at the end too.
This is passing all tests at the moment, and gone through visual testing with myself and on a client's site.
Edit: I was really busy the past month, and I've been meaning to reply to this for quite some time. Sorry for the delay.
Comment #6
altrugon commentedYou're welcome. I'm glad my code was useful.
Comment #7
mradcliffeCommitted.