Problem/Motivation

The test bot fails to install cck_select_other because the info.yml file does not contain the new core_version_requirement key.

Proposed resolution

First set the key, and set the value to ^8 || ^9. Then see what else fails. We should not need to make any major architectural changes at the moment, but only aim to fix deprecation failures that pop up.

Remaining tasks

Write an initial patch, and make sure that the tests run on Drupal 9 and Drupal 8.

CommentFileSizeAuthor
#2 allow_cck_select_other_to_be_installed_on_Drupal_9_0_x-3089761-1.patch2.16 KBfazni

Comments

mradcliffe created an issue. See original summary.

fazni’s picture

fazni commented
StatusFileSize
new allow_cck_select_other_to_be_installed_on_Drupal_9_0_x-3089761-1.patch2.16 KB
fazni’s picture

fazni commented
Status: Active » Needs review
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

This is awesome. Thank you, @fazni for figuring out the right deprecations and fixing them in the patch.

It looks like FieldFilteredMarkup is marked up by internal, but this is a contrib. field plugin. I think it's confusing that the deprecated trait links to an internal class.

I also queued the 9.0 testbot to see how it likes the patch.

fazni’s picture

fazni commented

Thank you @mradcliffe for your feedback, according to my understanding no issue to use it for this case i think, because this it should be used by the Field module and field-related plugins https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F..., but it's confusing for me as well.

  • mradcliffe committed c0bb70d on 8.x-1.x 
    Issue #3089761 by fazni: Fixes use of deprecated trait and updates for...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

I decided to commit the patch. I do think the new class should be considered for the public api and be part of the backwards-compatible policy. I'm going to file a core task issue about that. I found that @catch mentioned several years ago that @internal is iffy.

Thank you again for submitting the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.