As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#4 cck_select_other-2845198-remove-file-docblock-4.patch6.07 KBmradcliffe
#2 remove@file_2845198_1.patch6.07 KBnehakhadke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
FileSize
remove@file_2845198_1.patch6.07 KB

Status: Needs review » Needs work

The last submitted patch, 2: remove@file_2845198_1.patch, failed testing.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented
Status: Needs work » Needs review
FileSize
cck_select_other-2845198-remove-file-docblock-4.patch6.07 KB

Maybe it was the file name that caused the patch to fail to apply?

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented
Status: Needs review » Needs work

Looks like one still exists at src/Plugin/views/filter/SelectOtherField.php

Thanks for the patch.

  • mradcliffe committed 567f379 on 8.x-1.x 
    Issue #2845198 by nehakhadke, mradcliffe: Remove @file docblock from all...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.