Conflict with Image Resize Filter (processes all CCK fields when it should only process input filter fields) [#1358840]

Hi there,

I'm having an issue with this module as when it is enabled the Image Resize Filter module is being passed CCK fields that are not 'input filter'-controlled fields (i.e. file/image upload fields).

This issue contains steps to recreate the problem that has led me to this module:

http://drupal.org/node/1262824#comment-5314646

When scanning through the $text that comes to Image Resize Filter's image_resize_filter_get_images() function all CCK fields are found. Usually this function would just receive CCK fields (and body content) with an input filter using the 'Image Resize Filter' filter assigned, however your module seems to be causing this module to receive more fields than it should.

Clearing cached data (Performance admin setting page) between tests is important between tests as the node data is cached and will not display the same bug once the image has been created.

Comment	File	Size	Author
#1	filterfix-1358840.patch	519 bytes	sydneyshan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sydneyshan CreditAttribution: sydneyshan commented 2 December 2011 at 04:55

File	Size
filterfix-1358840.patch	519 bytes

Patch attached!

CCK Blocks runs node_build_content() on the $node object that has $node->body already rendered. This causes havoc in the bowels of Drupal as it runs the check_markup() function on the pre-rendered $node->body HTML markup.

In my case, the input filter 'Image Resize Filter' was picking up images in my CCK fields and processing them. This caused conflicts with EPSA Crop as Image Resize Filter was bypassing the custom cropping EPSA was supposed to apply therefore ImageCache stored a wrongly cropped image.

2 days of troubleshooting and one line of code to fix... !!

Please apply this patch :-) Thanks!

Comment #2

sydneyshan CreditAttribution: sydneyshan commented 5 December 2011 at 03:58

Status:

Active

» Needs review

Comment #3

damien_vancouver CreditAttribution: damien_vancouver commented 5 December 2011 at 06:02

Hi Sydneyshan,

I've just taken over maintaining cck_blocks for drupal 7 (and maybe 6 if no one of the old maintainers are available). I'll take a look at this in detail and see if I can't fix it properly. The same code runs in the Drupal 7 version of the module too and so I'm sure the bug exists there too.

Your steps to reproduce look great so when I have a chance I'll do that. I'll post back to this thread when I do.