Node Reference using Views returns only 1 result when there should be multiples

I have a similar issue in cennection with the user_relationships module.
I want a list of related users. This is the Views query:

SELECT users.uid AS uid,
   users_user_relationships.name AS users_user_relationships_name
 FROM users users 
 LEFT JOIN user_relationships user_relationships ON users.uid = user_relationships.requestee_id
 LEFT JOIN users users_user_relationships ON user_relationships.requester_id = users_user_relationships.uid
 WHERE (user_relationships.rtid in ('1', '2')) AND (user_relationships.requestee_id = ***CURRENT_USER***)

This gives me the correct number of results in the Views Preview. However, on the CCK select list only the last entry of the query is displayed.

The "add the uid field"-workaround (http://drupal.org/node/896874#comment-3823332) did not work for me.

This is on the 6.2.12 Views and the 6.2.9 CCK.

Same problem as 22. The views preview works fine, the noderef with a Node Title argument being sent only shows the last entry of the query.

I am using the 3.x dev of Views as well.

To reproduce:

Views 6.x-2.12
CCK 6.x-3.0-alpha3
(I have tried with combinations of Views 6.3x dev, CCK 2.9, etc. No fix with my scenario.)

You'll make 3 content types.

Make a content type:
course

Import the following session content type:

$content['type']  = array (
  'name' => 'Session',
  'type' => 'session',
  'description' => '',
  'title_label' => 'Title',
  'body_label' => 'Body',
  'min_word_count' => '0',
  'help' => '',
  'node_options' => 
  array (
    'status' => true,
    'promote' => true,
    'sticky' => false,
    'revision' => false,
  ),
  'old_type' => 'session',
  'orig_type' => '',
  'module' => 'node',
  'custom' => '1',
  'modified' => '1',
  'locked' => '0',
);
$content['fields']  = array (
  0 => 
  array (
    'label' => 'Courses',
    'field_name' => 'field_courses',
    'type' => 'nodereference',
    'widget_type' => 'nodereference_select',
    'change' => 'Change basic information',
    'weight' => '31',
    'autocomplete_match' => 'contains',
    'size' => 60,
    'description' => '',
    'default_value' => 
    array (
      0 => 
      array (
        'nid' => '',
      ),
    ),
    'default_value_php' => '',
    'default_value_widget' => NULL,
    'group' => false,
    'required' => 1,
    'multiple' => '1',
    'referenceable_types' => 
    array (
      'course' => 'course',
      'page' => 0,
      'registration' => 0,
      'session' => 0,
      'story' => 0,
      'courseselection' => false,
    ),
    'advanced_view' => '--',
    'advanced_view_args' => '',
    'op' => 'Save field settings',
    'module' => 'nodereference',
    'widget_module' => 'nodereference',
    'columns' => 
    array (
      'nid' => 
      array (
        'type' => 'int',
        'unsigned' => true,
        'not null' => false,
        'index' => true,
      ),
    ),
    'display_settings' => 
    array (
      'label' => 
      array (
        'format' => 'above',
        'exclude' => 0,
      ),
      'teaser' => 
      array (
        'format' => 'default',
        'exclude' => 0,
      ),
      'full' => 
      array (
        'format' => 'default',
        'exclude' => 0,
      ),
      4 => 
      array (
        'format' => 'default',
        'exclude' => 0,
      ),
    ),
  ),
);
$content['extra']  = array (
  'title' => '-5',
  'body_field' => '0',
  'revision_information' => '20',
  'author' => '20',
  'options' => '25',
  'menu' => '-2',
  'path' => '30',
);

Add 3 demo courses, 1 session. In the session make sure to reference TWO course nodes (important for viewing bug)

Import 1 view:

$view = new view;
$view->name = 'courses_registration_session';
$view->description = '';
$view->tag = '';
$view->view_php = '';
$view->base_table = 'node';
$view->is_cacheable = FALSE;
$view->api_version = 2;
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */
$handler = $view->new_display('default', 'Defaults', 'default');
$handler->override_option('relationships', array(
  'field_courses_nid' => array(
    'label' => 'Courses',
    'required' => 1,
    'delta' => '-1',
    'id' => 'field_courses_nid',
    'table' => 'node_data_field_courses',
    'field' => 'field_courses_nid',
    'relationship' => 'none',
  ),
));
$handler->override_option('fields', array(
  'title' => array(
    'label' => '',
    'alter' => array(
      'alter_text' => 0,
      'text' => '',
      'make_link' => 0,
      'path' => '',
      'link_class' => '',
      'alt' => '',
      'prefix' => '',
      'suffix' => '',
      'target' => '',
      'help' => '',
      'trim' => 0,
      'max_length' => '',
      'word_boundary' => 1,
      'ellipsis' => 1,
      'html' => 0,
      'strip_tags' => 0,
    ),
    'empty' => '',
    'hide_empty' => 0,
    'empty_zero' => 0,
    'link_to_node' => 0,
    'exclude' => 0,
    'id' => 'title',
    'table' => 'node',
    'field' => 'title',
    'relationship' => 'field_courses_nid',
  ),
));
$handler->override_option('arguments', array(
  'title' => array(
    'default_action' => 'not found',
    'style_plugin' => 'default_summary',
    'style_options' => array(),
    'wildcard' => 'all',
    'wildcard_substitution' => 'All',
    'title' => '',
    'breadcrumb' => '',
    'default_argument_type' => 'fixed',
    'default_argument' => '',
    'validate_type' => 'none',
    'validate_fail' => 'not found',
    'glossary' => 0,
    'limit' => '0',
    'case' => 'none',
    'path_case' => 'none',
    'transform_dash' => 0,
    'id' => 'title',
    'table' => 'node',
    'field' => 'title',
    'validate_user_argument_type' => 'uid',
    'validate_user_roles' => array(
      '2' => 0,
    ),
    'relationship' => 'none',
    'default_options_div_prefix' => '',
    'default_argument_fixed' => '',
    'default_argument_user' => 0,
    'default_argument_php' => '',
    'validate_argument_node_type' => array(
      'course' => 0,
      'courseselection' => 0,
      'page' => 0,
      'registration' => 0,
      'session' => 0,
      'story' => 0,
    ),
    'validate_argument_node_access' => 0,
    'validate_argument_nid_type' => 'nid',
    'validate_argument_vocabulary' => array(),
    'validate_argument_type' => 'tid',
    'validate_argument_transform' => 0,
    'validate_user_restrict_roles' => 0,
    'validate_argument_php' => '',
  ),
));
$handler->override_option('filters', array(
  'type' => array(
    'operator' => 'in',
    'value' => array(
      'session' => 'session',
    ),
    'group' => '0',
    'exposed' => FALSE,
    'expose' => array(
      'operator' => FALSE,
      'label' => '',
    ),
    'id' => 'type',
    'table' => 'node',
    'field' => 'type',
    'relationship' => 'none',
  ),
  'status' => array(
    'operator' => '=',
    'value' => '1',
    'group' => '0',
    'exposed' => FALSE,
    'expose' => array(
      'operator' => FALSE,
      'label' => '',
    ),
    'id' => 'status',
    'table' => 'node',
    'field' => 'status',
    'relationship' => 'none',
  ),
));
$handler->override_option('access', array(
  'type' => 'none',
));
$handler->override_option('cache', array(
  'type' => 'none',
));

Import the following for courseselection content type:

$content['type']  = array (
  'name' => 'Course Selection',
  'type' => 'courseselection',
  'description' => '',
  'title_label' => 'Title',
  'body_label' => '',
  'min_word_count' => '0',
  'help' => '',
  'node_options' => 
  array (
    'status' => true,
    'promote' => true,
    'sticky' => false,
    'revision' => false,
  ),
  'old_type' => 'courseselection',
  'orig_type' => '',
  'module' => 'node',
  'custom' => '1',
  'modified' => '1',
  'locked' => '0',
);
$content['fields']  = array (
  0 => 
  array (
    'label' => 'Session 5',
    'field_name' => 'field_session5',
    'type' => 'nodereference',
    'widget_type' => 'nodereference_buttons',
    'change' => 'Change basic information',
    'weight' => '-4',
    'autocomplete_match' => 'contains',
    'size' => 60,
    'description' => '',
    'default_value' => 
    array (
      0 => 
      array (
        'nid' => '',
      ),
    ),
    'default_value_php' => '',
    'default_value_widget' => NULL,
    'group' => false,
    'required' => 1,
    'multiple' => '0',
    'referenceable_types' => 
    array (
      'course' => 0,
      'courseselection' => 0,
      'page' => 0,
      'registration' => 0,
      'session' => 0,
      'story' => 0,
    ),
    'advanced_view' => 'courses_registration_session',
    'advanced_view_args' => 'Session 5',
    'op' => 'Save field settings',
    'module' => 'nodereference',
    'widget_module' => 'nodereference',
    'columns' => 
    array (
      'nid' => 
      array (
        'type' => 'int',
        'unsigned' => true,
        'not null' => false,
        'index' => true,
      ),
    ),
    'display_settings' => 
    array (
      'label' => 
      array (
        'format' => 'above',
        'exclude' => 0,
      ),
      'teaser' => 
      array (
        'format' => 'default',
        'exclude' => 0,
      ),
      'full' => 
      array (
        'format' => 'default',
        'exclude' => 0,
      ),
      4 => 
      array (
        'format' => 'default',
        'exclude' => 0,
      ),
    ),
  ),
);
$content['extra']  = array (
  'title' => '-5',
  'revision_information' => '-2',
  'author' => '-1',
  'options' => '0',
  'menu' => '-3',
  'path' => '1',
);

Go and try to create a course selection content type. You'll see that only ONE option comes up in the nodereference that sources the view. The view has a relationship and uses Node Title as the argument (defined in the course_selection Session 5 nodereference field). When you test out the view in preview with "Session 5" you get the full list of course nodes.

In CCK nodereference.module, this line is the first occurrence of the results only returning 1 when there are more:

$result = $view->execute_display($display, $view_args);

In function _nodereference_potential_references_views()

I don't have enough experience with Views to know what the problem is right away. I will be digging, but if anyone has quick insight it would be nice.

My solution to this isn't pretty but I made it work. It involves hacking the Views handler for nodereferences as well as using the nid workaround in the View. It also involves hardcoding the relationship nid field in the views handler so it thinks that nid is what it should use for the referenced fields.

I'd post it but it's definitely not the right way to fix this problem. I think what is required is an implementation of relationship recognition in the nodereference views handler since that doesn't seem to exist at all (oversight?).

Actually, I think it's more a CCK thing. Views happily returns the right results if using other views handlers. Using the noderef handler that interacts with Views, however, means that relationships aren't accounted for if they exist in the view.

I could be wrong though, but I assume it's up to that noderef handler to find out about relationships that exist in the view.

All of the tweaks I did to make this work were made in the CCK noderef (the views handler and the main module) code and not in Views. The only thing I did in Views is also reference the relationship's nid as a field so the CCK noderef handler could access it more easily. This is obviously very hacky and not the right way to fix this long term...

Here's my hack if anyone here is curious. I don't recommend it if you're using noderef views for a lot of other things, but it's nice if you want it for just a select few and need more than 1 result returned from a view with a relationship and argument...

cck/modules/nodereference/nodereference.module
~line 230, comment this portion out. This is the part I'm a little scared about since I'm removing some validation to push the relationships through

            /* Vilepickle hack 6/8, removed because it would always error out on relationships */
            /*if (!empty($item['nid']) && !isset($refs[$item['nid']])) {
              form_set_error($error_element, t("%name: this post can't be referenced.", array('%name' => t($field['widget']['label']))));
            }
             */
            /* Vilepickle hack 6/8 */

cck/includes/views/handlers/content_plugin_style_php_array_ac.inc
Copy of the entire file, I have indicated my hacky parts.

<?php

/**
 * @file
 * Handler for 'content_php_array_autocomplete' style.
 */
class content_plugin_style_php_array_ac extends views_plugin_style {

  function render () {
    $results = array ();

    // Group the rows according to the grouping field, if specified.
    $sets = $this->render_grouping ($this->view->result, $this->options['grouping']);

    $base_field = $this->view->base_field;

    /* Vilepickle hack 6/8 */
    if ($this->view->relationship) {
      $base_field = 'course';
    }
    /* Vilepickle hack 6/8 */

    $title_field = $this->display->display_options['content_title_field'];
    $title_field_alias = $this->view->field[$title_field]->field_alias;
    //dpm ($this->view);

    // TODO : We don't display grouping info for now.
    // Could be useful for select widget, though.
    $this->view->row_index = 0;
    foreach ($sets as $title => $records) {
      foreach ($records as $label => $row) {

       /* Vilepickle hack 6/8 */
        if ($base_field == 'course') {
          //This is hardcoded :(
          //Assign the nid to the correct NID for a relationship, field is specific to this reference...
          $row->nid = $row->node_node_data_field_courses_nid;
          $results[$row->nid] = array (
              'title' => $row->{$title_field_alias},
              'rendered' => $this->row_plugin->render ($row),
          );
          
        } else {
          //run the old code that doesn't do anything with relationships
          $results[$row->{$base_field}] = array (
              'title' => $row->{$title_field_alias},
              'rendered' => $this->row_plugin->render ($row),
          );
        }
        /* Vilepickle hack 6/8 */
        
        $this->view->row_index++;
      }
    }
    unset ($this->view->row_index);
    return $results;
  }

}

The very specific portion of this is "node_node_data_field_courses_nid" which is the view reference for my relationship's NID. You'd have to add a new one in for each different view you use in a nodereference. I got that exact name by using devel and dpm()