E_STRICT compliance [#2327005]

This is a small patch against 6.x-3.x to some views handler declarations, to prevent the warnings below when in an E_STRICT environment, such as PHP 5.4.

As necessity and opportunity allow, I hope to keep this this comprehensive and freshly rolled. I encourage others to post additional patches here, if they find further E_STRICT warnings, wherever they may be.

content_handler_field::element_type() should be compatible with views_handler_field::element_type($none_supported = false, $default_empty = false, $inline = false) in cck\includes\views\handlers\content_handler_field.inc on line 228.

Declaration of content_handler_field_multiple::query() should be compatible with views_handler_field::query($group_by = false) in cck\includes\views\handlers\content_handler_field_multiple.inc on line 321.

Declaration of content_handler_field_multiple::pre_render() should be compatible with views_handler_field::pre_render(&$values) in cck\includes\views\handlers\content_handler_field_multiple.inc on line 321.

Declaration of content_handler_field_multiple::element_type() should be compatible with content_handler_field::element_type($none_supported = false, $default_empty = false, $inline = false) in cck\includes\views\handlers\content_handler_field_multiple.inc on line 321.

Comment	File	Size	Author
#26	cck-e_strict-2327005-26.patch	2.85 KB	SeanA
#15	cck-e_strict-2327005-15.patch	3.21 KB	Michelle
#8	cck-e_strict-2327005-8.interdiff.txt	817 bytes	Michelle
#4	cck-e_strict-2327005-4.patch	2.41 KB	mw4ll4c3
#1	cck-e_strict-2327005-1.patch	1.87 KB	mw4ll4c3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mw4ll4c3 CreditAttribution: mw4ll4c3 commented 25 August 2014 at 01:47

File	Size
cck-e_strict-2327005-1.patch	1.87 KB

Comment #2

mw4ll4c3 CreditAttribution: mw4ll4c3 commented 25 August 2014 at 01:48

Status:

Active

» Needs review

Comment #3

mw4ll4c3 CreditAttribution: mw4ll4c3 commented 25 August 2014 at 01:51

Issue summary:

View changes

Comment #4

mw4ll4c3 CreditAttribution: mw4ll4c3 commented 25 August 2014 at 01:56

Issue summary:

View changes

File	Size
cck-e_strict-2327005-4.patch	2.41 KB

Comment #5

SeanA CreditAttribution: SeanA commented 16 April 2015 at 16:56

Status:

Needs review

» Reviewed & tested by the community

Thank you, patch in #4 fixes these warnings. Patch applied to CCK 6.x-2.9 succeeded with offsets.

Comment #6

mw4ll4c3 CreditAttribution: mw4ll4c3 commented 25 April 2015 at 17:38

Assigned:

mw4ll4c3

» Unassigned

Comment #7

roball CreditAttribution: roball commented 9 May 2015 at 01:08

Thank you mw4ll4c3 for the patch #4. I can confirm it fixes the error

Declaration of content_handler_field_multiple::pre_render() should be compatible with views_handler_field::pre_render(&$values) in /etc/drupal6/all/modules/cck/includes/views/handlers/content_handler_field_multiple.inc on line 321.

with CCK 6.x-3.0-alpha3+13-dev.

Comment #8

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle at Mediacurrent commented 21 June 2015 at 19:00

File	Size
cck-e_strict-2327005-8.interdiff.txt	817 bytes

I'm working off the 2.x branch and, even though the existing patch applied cleanly, I'm not so sure making a new patch off the wrong branch is a good idea so I'm just going to attach the interdiff for my addition.

This is to fix:

Strict warning: Only variables should be passed by reference in content_field_edit_form_validate() (line 1282 of /sites/all/modules/cck/includes/content.admin.inc).

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 June 2015 at 14:16

Parent issue:

» #2510648: Plan for CCK 6.x-3.0 release

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 June 2015 at 14:20

Closed a duplicate: #1962718: Strict warning: Declaration should be compatible

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 June 2015 at 14:22

Parent issue:	#2510648: Plan for CCK 6.x-3.0 release	» #2510646: Plan for CCK 6.x-2.11 release
Related issues:		+#2510648: Plan for CCK 6.x-3.0 release

FYI the patch still applies to the current 6.x-2.x.

Comment #12

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 26 June 2015 at 14:59

Closed a duplicate: #1463452: PHP 5.3 E_STRICT warning - declaration compatibility

Comment #13

Albert Volkman CreditAttribution: Albert Volkman commented 7 July 2015 at 12:55

+1 for RTBC

Comment #14

goldlilys CreditAttribution: goldlilys commented 22 July 2015 at 09:30

+1 for #4 patch

Comment #15

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle at Mediacurrent commented 23 July 2015 at 02:24

Status:

Reviewed & tested by the community

» Needs review

File	Size
cck-e_strict-2327005-15.patch	3.21 KB

1 file was hidden/shown/deleted

File	Size
cck-e_strict-2327005-8.interdiff.txt	817 bytes

I took the patch from #4 and added in my changes in #8 and made a combined patch against the 3.x branch.

Comment #16

mw4ll4c3 CreditAttribution: mw4ll4c3 commented 23 July 2015 at 05:01

Status:

Needs review

» Reviewed & tested by the community

Thank you for the formal patch. I've been using your change for a while, and confirm Patch #15 applies cleanly against 6.x-3.x

Not worth holding anything up, but: looking at that change again, I'm curious if the sequence couldn't just be

reset($form_values['default_value_widget']);
key($form_values['default_value_widget']);
$default_value = $form_values['default_value_widget'][$key];

or even just
$default_value = reset($form_values['default_value_widget']);

Comment #17

roball CreditAttribution: roball commented 23 July 2015 at 07:16

2 files were hidden/shown/deleted

File	Size
cck-e_strict-2327005-1.patch	1.87 KB
cck-e_strict-2327005-4.patch	2.41 KB

Comment #18

joachim CreditAttribution: joachim commented 4 August 2015 at 09:24

I can confirm that this patch also applies to 2.x, with slight fuzz.

Comment #19

dawehner

German

CreditAttribution: dawehner at Tag1 Consulting commented 8 September 2015 at 11:50

Works for me, thank you! Note https://www.drupal.org/node/2411093#comment-10304311 ... so the $group_by = FALSE change is not necessarily required.

Comment #20

Steel Rat CreditAttribution: Steel Rat commented 6 October 2015 at 03:02

I installed the 6.x.3.x alpha version, and made the patches in the head post, but I still get the date handler error from this thread: https://www.drupal.org/node/1948238

I was instructed to patch CCK from here since that's where the actual error is. Didn't help.

The upgrade to PHP and MySQL 5.5 has just been a disaster.

Comment #21

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 6 October 2015 at 09:23

Steel Rat: You need to patch CCK and Views too, and look through the list of PHP 5.4 and PHP 5.5 issues for other patches to apply.

Comment #22

Steel Rat CreditAttribution: Steel Rat commented 6 October 2015 at 14:07

Thanks Damien, but I'm thinking running a literal patchwork system is not a good idea.

I'll have to try to upgrade to D7 this weekend for one of my sites in particular that I use at work. But even then some of the modules I need are still in alpha. Frustrating.

Comment #23

roball CreditAttribution: roball commented 6 October 2015 at 16:53

@Steel Rat: rather than patching all D6 core modules having PHP 5.4 E_STRICT issues, I would recommend to just apply the one patch #1954296: Restore original D6 behaviour to prevent logging E_STRICT warnings.

Comment #24

Steel Rat CreditAttribution: Steel Rat commented 7 October 2015 at 03:10

@roball

Done, thanks!

Comment #25

roball CreditAttribution: roball commented 7 October 2015 at 05:28

Comment #26

SeanA CreditAttribution: SeanA commented 25 November 2015 at 03:45

File	Size
cck-e_strict-2327005-26.patch	2.85 KB

Per dawehner at #19, this is not necessary:

-  function query() {
+  function query($group_by = false) {

Because the patch for Views over there does this:

+   *
+   * @param bool $group_by
+   *   (optional) Whether the view is using an aggregation query. If you
+   *    override this method you can specify $group_by as optional parameter.
    */
-  function query($group_by = FALSE) { }
+  function query() { }

This patch is identical to the last patch, without the $group_by = false part. Applies to both 6.x-2.x and 6.x-3.x.