Problem/Motivation

The External Authentication module has a new 2.0.x release branch. It would be great if CAS were compatible with the new 2.0.x releases.

Judging by the 2.0.0 release notes, the 2.0.x branch doesn't seem to introduce any backwards incompatible changes other than that it drops support for Drupal 8.

Proposed resolution

Update CAS module's composer.json version constraint for drupal/externalauth to include ^2.0.

Remaining tasks

Create patch, review, commit.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork cas-3291020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joegraduate created an issue. See original summary.

joegraduate’s picture

Title: Support External Auth 2.0.x » Support Externalauth 2.0.x
joegraduate’s picture

Status: Active » Needs review
bkosborne’s picture

I don't know about that change you needed to add to prevent passing NULL to that authmap method. I'm not sure why our tests would ever be passing NULL. I reverted that change locally and ran the functional tests and they all passed... so I'll try again with your merge request and see if they still fail.

joegraduate’s picture

Uploading MR diff as patch to see if test results are any different.

Status: Needs review » Needs work

The last submitted patch, 6: 3291020-6.patch, failed testing. View results

bkosborne’s picture

Status: Needs work » Fixed

Looks good, thank you!

xeM8VfDh’s picture

Sorry about the duplicate @bkosborne, I search but didn't find this one. Glad to see this is already fixed! Any idea when it will make it into a new CAS release?

bkosborne’s picture

xeM8VfDh’s picture

wow, amazing, thanks you!

Monster971’s picture

Category: Feature request » Bug report
Status: Fixed » Needs work

After updating CAS 2.0.1 and ExternalAuth 2.0.2 module, when I want to add users via /admin/people/create,

I have the following error:

TypeError: Argument 1 passed to Drupal\externalauth\Authmap::get() must be of the type int, null given, called in /var/www/html/unc/web/modules/contrib/cas/src/Service/CasUserManager .php on line 273 in Drupal\externalauth\Authmap->get() (/var/www/html/unc/web/modules/contrib/externalauth/src/Authmap.php line 57)

I'm on Drupal 9.4.5.

bkosborne’s picture

Thanks. Looks like we have some missing test coverage then. I'll take a look

  • bkosborne committed 6827fb0 on 2.x
    Issue #3291020 by bkosborne: Fix support for external auth 2.0.x, we...
bkosborne’s picture

Status: Needs work » Fixed

This should be fixed now in version 2.0.2. Thanks for reporting quickly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.