Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The External Authentication module has a new 2.0.x release branch. It would be great if CAS were compatible with the new 2.0.x releases.
Judging by the 2.0.0 release notes, the 2.0.x branch doesn't seem to introduce any backwards incompatible changes other than that it drops support for Drupal 8.
Proposed resolution
Update CAS module's composer.json version constraint for drupal/externalauth to include ^2.0.
Remaining tasks
Create patch, review, commit.
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#6 | 3291020-6.patch | 418 bytes | joegraduate |
Issue fork cas-3291020
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
joegraduateComment #4
joegraduateComment #5
bkosborneI don't know about that change you needed to add to prevent passing NULL to that authmap method. I'm not sure why our tests would ever be passing NULL. I reverted that change locally and ran the functional tests and they all passed... so I'll try again with your merge request and see if they still fail.
Comment #6
joegraduateUploading MR diff as patch to see if test results are any different.
Comment #9
bkosborneLooks good, thank you!
Comment #10
xeM8VfDh CreditAttribution: xeM8VfDh commentedSorry about the duplicate @bkosborne, I search but didn't find this one. Glad to see this is already fixed! Any idea when it will make it into a new CAS release?
Comment #11
bkosborneToday!
Comment #12
xeM8VfDh CreditAttribution: xeM8VfDh commentedwow, amazing, thanks you!
Comment #13
Monster971After updating CAS 2.0.1 and ExternalAuth 2.0.2 module, when I want to add users via /admin/people/create,
I have the following error:
TypeError: Argument 1 passed to Drupal\externalauth\Authmap::get() must be of the type int, null given, called in /var/www/html/unc/web/modules/contrib/cas/src/Service/CasUserManager .php on line 273 in Drupal\externalauth\Authmap->get() (/var/www/html/unc/web/modules/contrib/externalauth/src/Authmap.php line 57)
I'm on Drupal 9.4.5.
Comment #14
bkosborneThanks. Looks like we have some missing test coverage then. I'll take a look
Comment #16
bkosborneThis should be fixed now in version 2.0.2. Thanks for reporting quickly.