Depending on the exact situation, this module makes one or more HTTP requests to the CAS server using Guzzle (the HTTP library). We are not currently specifying a timeout value for these requests, which could be dangerous if there is some problem with the CAS server. It could cause the Drupal site (acting as a client) to hang while it waits a long time for that request to complete, potentially taking down the Drupal site as more and more PHP processes are consumed with this networking wait.
The solution is to specify a reasonable timeout value for the HTTP requests that we make to the CAS server. I think a good default is 5 seconds. Could even add this as a config option under an "advanced" fieldset.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | connection-timeout-2838660.patch | 7.32 KB | bkosborne |
Comments
Comment #2
metzlerd commentedI would definitely advocate for this, but 5 seconds seems a bit short for default, maybe 10?
Comment #3
bkosborneComment #5
bkosborneI went with 10 seconds as suggested. I agree that's a more reasonable time.