Warning: Call-time pass-by-reference has been deprecated in /captcha.install on line 306 [#844148]

Comment #1

AntiNSA CreditAttribution: AntiNSA commented 3 July 2010 at 06:15

also get this when trying to update

warning: Cannot modify header information - headers already sent by (output started at /home/cyberfan/htdocs/sites/all/modules/captcha/captcha.install:306) in /home/cyberfan/htdocs/includes/common.inc on line 148.

Log in or register to post comments

Comment #2

soxofaan CreditAttribution: soxofaan commented 3 July 2010 at 07:19

Version:	6.x-2.x-dev	» 7.x-1.x-dev
Category:	bug	» task
Priority:	Critical	» Normal
Status:	Active	» Patch (to be ported)

This one should fix this: http://drupal.org/cvs?commit=387570

Did the update succeed apart from the error message?

to be ported to Drupal 7 version

Log in or register to post comments

Comment #3

travisnapoleansmith CreditAttribution: travisnapoleansmith commented 20 July 2010 at 16:21

Version:	7.x-1.x-dev	» 6.x-2.2
Category:	task	» bug
Priority:	Normal	» Critical

This should be fixed and released as a RTM immediately. I updated the software because of a security issue and it has caused my site to not work. ALL MODULES should be testing in both PHP 4 and 5. This release should not have been released because it totally does not work on any system using PHP 5. When someone downloads this module for any Drupal site using PHP 5 it will not work because of this. With this message a user cannot uninstall it and is not good development practice.

Please make sure to test in both PHP 4 and 5 before an RTM. This should not have been in the RTM of this module!

Log in or register to post comments

Comment #4

travisnapoleansmith CreditAttribution: travisnapoleansmith commented 20 July 2010 at 16:26

It was in the captcha.install file and was on line 306. Removed the reference symbol on the function call db_add_column.

Log in or register to post comments

Comment #5

travisnapoleansmith CreditAttribution: travisnapoleansmith commented 20 July 2010 at 16:27

Version:

6.x-2.2

» 6.x-2.3-rc1

Just updated version to 6.x-2.3-rc1

Log in or register to post comments

Comment #6

soxofaan CreditAttribution: soxofaan commented 20 July 2010 at 18:31

Version:	6.x-2.3-rc1	» 7.x-1.x-dev
Category:	bug	» task
Priority:	Critical	» Normal

Please don't over-exaggerate: the bug is only in the upgrade path to CAPTCHA 6.x-2.3-RC1, so a non-upgrade install does not suffer from it. The release description of 6.x-2.3-RC1 also clearly states that and why it lacked broad testing, and that it should not be used blindly on production sites.

Anyway, the fix is now included in the freshly released CAPTCHA 6.x-2.3-rc2.

Still to be ported to D7, when #810534: Fix CAPTCHA session reuse is ported.