The patch on https://www.drupal.org/node/1395184 checks whether $form_state->getTriggeringElement()['#limit_validation_errors'] is not empty. This will be an empty array if the ajax call doesn't want any validation to occur (https://api.drupal.org/api/drupal/developer!topics!forms_api_reference.h...)

Instead it should check if it is an array.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arknoll created an issue. See original summary.

arknoll’s picture

Status: Active » Needs review
FileSize
853 bytes
sk33lz’s picture

Status: Needs review » Reviewed & tested by the community

#2 applies cleanly and fixes the error even on 8.x-1.0-alpha1. I think this is RTBC in my book.

B N Pandey’s picture

Assigned: arknoll » B N Pandey
Status: Reviewed & tested by the community » Needs review
FileSize
1.24 KB

I fixed my issue in a different way.
Providing patch here.

Status: Needs review » Needs work

The last submitted patch, 4: captcha-session-reuse-attack-detected-2814137-4-D8.patch, failed testing.

Sam152’s picture

Status: Needs work » Reviewed & tested by the community

As #4 points out, it seems strange to me there is a db_update which is never executed. This was cropping up for me when click "Remove" on an inline_entity_form entity on a registration page. #2 does indeed solve the problem for me, so +1 to RTBC.

wundo’s picture

Status: Reviewed & tested by the community » Needs work

My impression is that we should commit #2 not #4.

Can we get the test passing before committing this please? Looks like the patch needs a re-roll.

Berdir’s picture

Status: Needs work » Reviewed & tested by the community

Agreed, #2 worked for us. It is also still still passing, I'll request another test after posting this to be sure.

B N Pandey’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
999 bytes

I got this error when I submit registration form. I applied the patch provided in comment #2 but it does not work for me. So I fixed my issue in a new way. Please review it.

Status: Needs review » Needs work

The last submitted patch, 9: captcha-session-reuse-attack-detected-2814137-9-D8.patch, failed testing.

elachlan’s picture

B N Pandey’s picture

Hi @elachlan,

May be both are related because issue in both the case are same.

elachlan’s picture

Could you re-roll the patch?

B N Pandey’s picture

Hi @elachlan,

Please explain how to re-roll path and why it's required?

  • elachlan committed d6d81bc on 8.x-1.x authored by arknoll
    Issue #2814137 by B N Pandey, arknoll: Ajax in forms still creates...
Berdir’s picture

Status: Needs work » Fixed

Looks like this was committed but not closed?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.