I was reviewing #2773767: deprecated function db_delete and saw the captcha_cron needed a test.

CommentFileSizeAuthor
#8 captcha-cron-test-fixes.patch4.17 KBddrozdik
#4 2783351-cron_test-3.patch2.53 KBkerby70
cron_test.patch2.56 KBkerby70
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kerby70 created an issue. See original summary.

kerby70’s picture

kerby70 CreditAttribution: kerby70 at FFW commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, cron_test.patch, failed testing.

kerby70’s picture

kerby70 CreditAttribution: kerby70 at FFW commented
FileSize
2783351-cron_test-3.patch2.53 KB

Missed a newline at EOF.

  • elachlan committed 181914a on 8.x-1.x authored by kerby70 
    Issue #2783351 by kerby70: Cron test - Verify old captcha session are...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs work » Fixed

Thanks for your work on this. More tests are always good.

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW for FFW commented
Status: Fixed » Needs work

I see that after adding these tests other patches are failing https://www.drupal.org/pift-ci-job/461381
Need to investigate this issue.

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik as a volunteer and at FFW for FFW commented
Status: Needs work » Needs review
FileSize
captcha-cron-test-fixes.patch4.17 KB

I have prepared a patch which fix all issues related to this test. Also I have removed all unnecessary things from this test.

  • elachlan committed 2fca8b7 on 8.x-1.x authored by ddrozdik 
    Issue #2783351 by kerby70, ddrozdik: Cron test - Verify old captcha...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs review » Fixed
elachlan’s picture

elachlan CreditAttribution: elachlan commented

Thanks for your work on solving this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.